Fix: Incomplete history import for marked as watched videos#9201
Open
Shadorc wants to merge 2 commits into
Open
Fix: Incomplete history import for marked as watched videos#9201Shadorc wants to merge 2 commits into
Shadorc wants to merge 2 commits into
Conversation
auto-merge was automatically disabled
May 27, 2026 23:21
Head branch was pushed to by a user without write access
PikachuEXE
approved these changes
May 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
closes #9021
Description
When video data are parsed from video list, 'description' seems to always be undefined. When the video is marked as watched manually, the same data is used to insert it in the watch history database. This leads to 'description' field not being part of the exported data. However, it is a required field when importing, leading to the exception.
The fix is to mark this 'description' field as optional. It is already the case when importing from YouTube watch history.
Also, I didn't find where this 'description' field was used, if used.
Testing
Desktop