Skip to content

fix: バージョン文字列の先頭の'v'を除去して更新確認の失敗を修正#196

Merged
Freeesia merged 4 commits into
masterfrom
copilot/fix-update-confirmation-processing
Apr 5, 2026
Merged

fix: バージョン文字列の先頭の'v'を除去して更新確認の失敗を修正#196
Freeesia merged 4 commits into
masterfrom
copilot/fix-update-confirmation-processing

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 5, 2026

GitHubリリースのタグ名が v1.2.3 形式になったことで、new Version("v1.2.3")FormatException をスローし、更新確認処理が失敗していた。

変更内容

  • ParseVersionヘルパーメソッドを追加: バージョン文字列の先頭の v/V を除去してから Version を生成
  • バージョン比較をParseVersion()に統一: CheckAndDownload (×2) と Check (×1) の全比較箇所を置き換え
  • release.Namerelease.TagName に統一: 比較・保存・ログ・通知で一貫してタグ名を使用
// Before — FormatException with "v1.2.3"
if (new Version(release.Name) <= this.version)

// After
private static Version ParseVersion(string version) => new(version.TrimStart('v', 'V'));

if (ParseVersion(release.TagName) <= this.version)

Copilot AI linked an issue Apr 5, 2026 that may be closed by this pull request
Copilot AI changed the title [WIP] Fix update confirmation processing for release version prefix fix: バージョン文字列の先頭の'v'を除去して更新確認の失敗を修正 Apr 5, 2026
Copilot AI requested a review from Freeesia April 5, 2026 07:50
@Freeesia Freeesia marked this pull request as ready for review April 5, 2026 07:50
@Freeesia Freeesia merged commit 4295d77 into master Apr 5, 2026
6 checks passed
@Freeesia Freeesia deleted the copilot/fix-update-confirmation-processing branch April 5, 2026 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

更新確認処理に失敗する

2 participants