Fix for php8#472
Conversation
Optional arg value of 'log' on private function _log not required and breaks PHP 8 as all calls provide a value
|
Thanks @alanef! |
|
Please forgive me if this belongs to another ticket, but in addition to the deprecation notice on line 145, I get thee "Cannot modify header information" warnings on my PHP 8.0.0 test bench, warnings that were not thrown running PHP 7.4.x Complete output when activating plugin using Freemius under PHP 8.0.0: Deprecated: Required parameter $wrapper follows optional parameter $type in /home/oldrupdk/oldrup.net/wp-content/plugins/content-aware-sidebars/lib/freemius/includes/class-fs-logger.php on line 145 Warning: Cannot modify header information - headers already sent by (output started at /home/oldrupdk/oldrup.net/wp-content/plugins/content-aware-sidebars/lib/freemius/includes/class-fs-logger.php:145) in /home/oldrupdk/oldrup.net/wp-includes/functions.php on line 6360 Warning: Cannot modify header information - headers already sent by (output started at /home/oldrupdk/oldrup.net/wp-content/plugins/content-aware-sidebars/lib/freemius/includes/class-fs-logger.php:145) in /home/oldrupdk/oldrup.net/wp-admin/includes/misc.php on line 1310 Warning: Cannot modify header information - headers already sent by (output started at /home/oldrupdk/oldrup.net/wp-content/plugins/content-aware-sidebars/lib/freemius/includes/class-fs-logger.php:145) in /home/oldrupdk/oldrup.net/wp-admin/admin-header.php on line 9 Best regards |
|
The warnings as far as I can see are directly related to the preceding Deprecated notice. |
3 participants
Unnecessary optional arg ( all calls provide a value) on private function _log line 145 of includes/class-fs-logger.php breaks PHP 8