Re-render app docker-compose templates on startup#49
Merged
Conversation
After a core update, settings like the DNS zone may change, but installed apps keep their previously rendered docker-compose.yml with stale values (e.g. old domain in Vaultwarden's DOMAIN env var). This re-renders all app templates from their existing .template files on every startup, ensuring they always reflect the current shard identity and paths. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docker-compose.ymlfiles from their.templatefiles on every shard_core startupp.getportal.orgdomain in their rendered docker-compose, causing auth failuresDetails
After a core update that changes the DNS zone (e.g.
p.getportal.org→freeshard.cloud), the core containers pick up the new domain via.env, but installed apps retain their previously rendereddocker-compose.ymlwith stale template values. This adds a startup step that re-renders all templates using the current identity, making it a no-op when nothing changed.Test plan
.templatefile (if any) are skipped gracefully🤖 Generated with Claude Code