fix(backup): serialize datetime in directories JSONB#74
Merged
Conversation
psycopg's Jsonb uses stdlib json.dumps which can't serialize datetime. Pass BackupReport directly to insert() and dump nested BackupStats with mode="json" so datetimes become ISO strings for JSONB, while top-level timestamps stay as datetime objects for timestamp columns. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TypeError: Object of type datetime is not JSON serializablewhen inserting report row.Jsonb(...)uses stdlibjson.dumps, which can't serializedatetime.BackupStats.startTime/endTimeinsidedirectoriesare datetimes.db_backups.insertnow takesBackupReportdirectly and dumps nestedBackupStatswithmode="json"(ISO strings) for the JSONB column, while keeping top-levelstartTime/endTimeasdatetimefor the timestamp columns.Test plan
backupstable with correctdirectoriesJSON and validstart_time/end_time.GETlast backup via existing endpoint — confirm roundtrip parses back intoBackupReport.🤖 Generated with Claude Code