Skip to content

[pull] master from goldbergyoni:master#100

Merged
pull[bot] merged 2 commits intoFreezeSoul:masterfrom
goldbergyoni:master
Jul 15, 2021
Merged

[pull] master from goldbergyoni:master#100
pull[bot] merged 2 commits intoFreezeSoul:masterfrom
goldbergyoni:master

Conversation

@pull
Copy link
Copy Markdown

@pull pull bot commented Jul 15, 2021

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

rluvaton added 2 commits July 14, 2021 20:05
… new line before them

Must have new lines before the HTML comments as it will fail without.

I assume that when they are right after the HTML the parsing done by Docusaurus thinks this comments are part of the HTML which will try to convert it into a React component which will which would fail the build as HTML comments in React are unsupported
 (instead of `<!-- some comment -->` you need to do `{/* comment */}`)
@pull pull bot added the ⤵️ pull label Jul 15, 2021
@pull pull bot merged commit a9e633b into FreezeSoul:master Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant