Skip to content

Conversation

@euhrich23
Copy link
Contributor

This addresses Issue #2147

This change implements ability 3 Pistol Shot and Ability 4 Rifle Assassin for the bounty hunter specifics of these abilities can be found in the issue.

@vercel
Copy link

vercel bot commented Apr 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ancientbeast ✅ Ready (Inspect) Visit Preview Apr 23, 2025 1:27am

@DreadKnight
Copy link
Member

@euhrich23 Pistol Shot should only show targetable directions is there are units along the ways, similar to Riffle Assassin.

Riffle Assassin seems to not deal any damage at all.

Comment consistency wise this sort of fails from before, so will let that slip and tweak that up myself eventually:

  • only ability titles should be mentioned in comments
  • comments should start capitalized

I'll see about merging #2489 in a bit so that it doesn't goes too stale and creates conflicts; so hopefully you'll be able to pull master in soon without issues.

@DreadKnight DreadKnight marked this pull request as draft April 23, 2025 06:01
@DreadKnight
Copy link
Member

@euhrich23 Any progress on this? 2 weeks passed 🐻

@DreadKnight
Copy link
Member

@euhrich23 sigh Really hoped we could wrap this new playable unit up; the cardboard just got added for it.

@DreadKnight DreadKnight mentioned this pull request May 27, 2025
@DreadKnight
Copy link
Member

@euhrich23 Poke 🐻

@missingno999
Copy link
Contributor

Hey, if those are the only two problems, could you try merging this branch, and let me clean it up? It seems like it should be pretty quick and easy.

@DreadKnight
Copy link
Member

Hey, if those are the only two problems, could you try merging this branch, and let me clean it up? It seems like it should be pretty quick and easy.

@missingno999 heya! You could have forked this PR in theory and made a new PR based on it. I will merge and you can poke at the stuff 🐻

@DreadKnight DreadKnight marked this pull request as ready for review June 27, 2025 00:33
@DreadKnight DreadKnight merged commit f815689 into FreezingMoon:master Jun 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants