Skip to content

Conversation

@aledeg
Copy link
Member

@aledeg aledeg commented Oct 10, 2025

The compatibility does support only a minimum version of FreshRSS. If we need
something a bit more clever in the future, it is possible to handle a rule
with a bit more complexity.

See #5903

Changes proposed in this pull request:

How to test the feature manually:

Pull request checklist:

  • clear commit messages
  • code manually tested
  • unit tests written (optional if too hard)
  • documentation updated

Additional information can be found in the documentation.

@aledeg
Copy link
Member Author

aledeg commented Oct 10, 2025

@Alkarex This is a first draft for the support of extension compatibility. Is there something else to add for a first version or we'll start with that?

I'll work on the extension list generation after this is completed.

@Alkarex Alkarex added this to the 1.28.0 milestone Oct 10, 2025
@Alkarex Alkarex linked an issue Oct 10, 2025 that may be closed by this pull request
@Inverle
Copy link
Member

Inverle commented Oct 10, 2025

There has to be a white-space: nowrap CSS rule on the <th> element:

image

@aledeg
Copy link
Member Author

aledeg commented Oct 11, 2025

There has to be a white-space: nowrap CSS rule on the <th> element:
image

What would be the css selector to apply that rule. I don't think I can apply it on th directly, the impact would be to important.
Do you have any idea?

@Inverle
Copy link
Member

Inverle commented Oct 11, 2025

div.table-wrapper th?

@Frenzie
Copy link
Member

Frenzie commented Oct 11, 2025

You could always just add a class to that column (though I don't necessarily know if I agree with the comment :p)

@Alkarex
Copy link
Member

Alkarex commented Oct 12, 2025

/fix-all

@github-actions
Copy link

🤖 Command /fix-all received. Running…

@github-actions
Copy link

⚠️ Command /fix-all ran successfully, but changes could not be pushed.

  • Please check that your PR settings “Allow edits from maintainers” is enabled.
  • Or run make fix-all locally and push to your branch.

@Alkarex
Copy link
Member

Alkarex commented Oct 12, 2025

/fix-all

@github-actions
Copy link

🤖 Command /fix-all received. Running…

@github-actions
Copy link

⚠️ Command /fix-all ran successfully, but changes could not be pushed.

  • Please check that your PR settings “Allow edits from maintainers” is enabled.
  • Or run make fix-all locally and push to your branch.

@Alkarex
Copy link
Member

Alkarex commented Oct 12, 2025

/fix-all

@github-actions
Copy link

🤖 Command /fix-all received. Running…

@github-actions
Copy link

🔧 Command /fix-all made some fixes and committed as fa0d18e

@Alkarex
Copy link
Member

Alkarex commented Oct 12, 2025

Sorry @aledeg for using your PR as a test for implementing a new GitHub Action:

I had to try a few times to get it to work...

@Alkarex Alkarex mentioned this pull request Oct 12, 2025
@aledeg
Copy link
Member Author

aledeg commented Oct 12, 2025

@Alkarex I think there is a rounding error when computing the completeness of translation. Maybe not an error but an incertainty.

@Alkarex
Copy link
Member

Alkarex commented Oct 12, 2025

@Alkarex I think there is a rounding error when computing the completeness of translation. Maybe not an error but an incertainty.

When new strings are added as is the case in this PR, then it is expected that the percentage will change

@aledeg
Copy link
Member Author

aledeg commented Oct 12, 2025

@Alkarex I think there is a rounding error when computing the completeness of translation. Maybe not an error but an incertainty.

When new strings are added as is the case in this PR, then it is expected that the percentage will change

I mean that I ran the command make readme multiple times on my machine to fix that but there was not change detected. But on the CI/CD, changes were detected.

@Alkarex
Copy link
Member

Alkarex commented Oct 12, 2025

Try make fix-all (I have not tried the other ones in a long time, except make test-all)

@Alkarex
Copy link
Member

Alkarex commented Oct 12, 2025

I mean that I ran the command make readme multiple times on my machine to fix that but there was not change detected. But on the CI/CD, changes were detected.

Ah, but I cannot remember what the status was, but this might also be due to the fact that when updating the branch, it may import new strings that have recently been merged

The compatibility does support only a minimum version of FreshRSS. If we need
something a bit more clever in the future, it is possible to handle a rule
with a bit more complexity.

See FreshRSS#5903
aledeg and others added 4 commits October 14, 2025 21:33
Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
Co-authored-by: Inverle <inverle@proton.me>
@aledeg aledeg force-pushed the extension/version branch from 09b83b9 to 3a7eec2 Compare October 15, 2025 01:34
@aledeg
Copy link
Member Author

aledeg commented Oct 15, 2025

I've messed up. I've needed to make a rebase.

@aledeg aledeg marked this pull request as ready for review October 15, 2025 01:37
@Alkarex Alkarex merged commit eee8b8c into FreshRSS:edge Oct 21, 2025
1 check passed
@aledeg aledeg deleted the extension/version branch October 21, 2025 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add compatibility range for extensions

4 participants