Keep scroll state of page when closing the slider

[Inverle]

When closing a slider (tested extension slider and configure feed slider), the page would scroll to the top which is unexpected.

[Inverle]

This pattern is already used more often than href="#" so using href="#" seems like a mistake.

$ git grep -irn 'href="#close' app
app/install.php:798:            <a class="toggle_aside" href="#close"><img class="icon" src="../themes/icons/close.svg" loading="lazy" alt="❌"></a>
app/install.php:838:    <a class="close-aside" href="#close">❌</a>
app/layout/aside_configure.phtml:8:     <a class="toggle_aside" href="#close"><?= _i('close') ?></a>
app/layout/aside_configure.phtml:111:<a class="close-aside" href="#close">❌</a>
app/layout/aside_feed.phtml:24: <a class="toggle_aside" href="#close"><?= _i('close') ?></a>
app/layout/aside_feed.phtml:164:<a class="close-aside" href="#close">❌</a>
app/layout/aside_feed.phtml:175:        <a class="dropdown-close" href="#close">❌</a>
app/layout/aside_feed.phtml:204:        <a class="dropdown-close" href="#close">❌</a>
app/layout/aside_subscription.phtml:5:  <a class="toggle_aside" href="#close"><?= _i('close') ?></a>
app/layout/aside_subscription.phtml:62: <a class="close-aside" href="#close">❌</a>
app/layout/header.phtml:60:                             <li class="dropdown-header-close"><a class="toggle_aside" href="#close"><?= _i('close') ?></a></li>
app/layout/header.phtml:124:                    <a class="dropdown-close" href="#close">❌</a>
app/layout/nav_menu.phtml:67:                   <a class="dropdown-close" href="#close">❌</a>
app/layout/nav_menu.phtml:103:                  <a class="dropdown-close" href="#close">❌</a>
app/layout/nav_menu.phtml:193:                  <a class="dropdown-close" href="#close">❌</a>
app/layout/nav_menu.phtml:277:                  <a class="dropdown-close" href="#close">❌</a>
app/views/configure/queries.phtml:73:<a class="toggle_aside" href="#close"><img class="icon" src="../themes/icons/close.svg" loading="lazy" alt="❌"></a>
app/views/helpers/index/normal/entry_bottom.phtml:63:                   <a class="dropdown-close" href="#close">❌</a>
app/views/helpers/index/tags.phtml:44:                          <a class="dropdown-close" href="#close">❌</a>
app/views/index/global.phtml:21:        <a class="dropdown-close" href="#close">❌</a>
app/views/index/global.phtml:36:        <a class="dropdown-close" href="#close">❌</a>
app/views/index/normal.phtml:21:        <a class="dropdown-close" href="#close">❌</a>
app/views/index/normal.phtml:36:        <a class="dropdown-close" href="#close">❌</a>
app/views/index/normal.phtml:189:       <a class="toggle_aside" href="#close"><img class="icon" src="../themes/icons/close.svg" loading="lazy" alt="❌"></a>
app/views/index/reader.phtml:65:        <a class="toggle_aside" href="#close"><?= _i('close') ?></a>
app/views/stats/idle.phtml:64:  <a class="toggle_aside" href="#close"><img class="icon" src="../themes/icons/close.svg" loading="lazy" alt="❌"></a>
app/views/subscription/index.phtml:94:  <a class="toggle_aside" href="#close"><img class="icon" src="../themes/icons/close.svg" loading="lazy" alt="❌"></a>
app/views/tag/index.phtml:41:   <a class="toggle_aside" href="#close"><img class="icon" src="../themes/icons/close.svg" loading="lazy" alt="❌"></a>
app/views/user/manage.phtml:129:<a class="toggle_aside" href="#close"><img class="icon" src="../themes/icons/close.svg" loading="lazy" alt="❌"></a>

[Frenzie]

I'm somewhat surprised the preventDefault wouldn't do that. But yes, better to do it this way.

Btw, the cancel button doesn't seem to work.

Edit: it's just a reset button. The name seems a bit misleading in that case.