fix: add graceful fallback when ColorBrewer palette loading fails offline#1
Merged
FridrichMethod merged 1 commit intoFridrichMethod:mainfrom Mar 27, 2026
Conversation
…line Wrap the urllib.request.urlopen() call in _load_colorbrewer() with try/except to handle network failures gracefully. When offline or the remote gist is unreachable, PyMOL will now print a warning and continue startup normally instead of crashing with an unhandled exception. Changes: - Add try/except around the HTTP request in _load_colorbrewer() - Add timeout=5 to prevent long hangs on slow/unreachable networks - Print a descriptive warning message on failure and return early
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
_load_colorbrewer()callsurllib.request.urlopen(url)without any error handling. When the network is unavailable (offline, DNS failure, firewall, etc.), this raises an unhandled exception that prevents PyMOL from starting normally.Solution
try/exceptblocktimeout=5to avoid long hangs on slow/unreachable networksreturnearly — PyMOL continues startup without ColorBrewer palettesChanges