Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several security and privacy improvements to the handling of CXml messages. The main focus is on protecting sensitive information (like shared secrets) in logs and error messages, enhancing authentication security, and improving XML parsing security.
Key security and privacy improvements:
Sensitive Data Redaction in Logs and Errors:
Endpoint.phpto redact shared secrets from CXml payloads before logging, preventing sensitive information from appearing in logs. This is achieved by introducing a newremoveSharedSecretmethod and applying it to all relevant log statements. [1] [2] [3]CXmlInvalidException.phpto redact shared secrets from XML included in error messages.Authentication Security Enhancements:
hash_equals()in bothSimpleSharedSecretAuthenticator.phpandRegistry.phpfor constant-time comparison, mitigating timing attacks. [1] [2]XML Parsing Security:
DtdValidator.phpto disable network access (LIBXML_NONET), reducing the risk of XML External Entity (XXE) attacks.