_getSingleEntity adjusted for null case #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For when $entities->first() returns null
Return an empty entity if resultSet is empty.
Collaborator
Author
|
@here I don't understand why this is failing – I actually added a test and I didn't add any methods to the main code, just an extra line or two of code. I don't know how to resolve this, so a little help would be appreciated! Thanks in advance. |
dakota
reviewed
Mar 31, 2020
| $this->setReflectionClassInstance($listener); | ||
| $result = $this->callProtectedMethod('_getSingleEntity', [$subject], $listener); | ||
|
|
||
| $this->assertInstanceOf('Cake\ORM\Entity', $result); |
Member
There was a problem hiding this comment.
Please use Entity::class instead of a class name string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that e.g. for an empty table, the
->first()call would return null, causing an _getSingleEntity to return null instead of an entity object, which caused an error to be thrown because_extractEntityAssociationsexpects an entity to be passed in.See: #108