Revert "Replace DOMAIN_SETTINGS with TM_SETTINGS" #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR reverts PR #2, which had replaced DOMAIN_SETTINGS with TM_SETTINGS throughout the codebase. The revert restores the original DOMAIN_SETTINGS naming convention used to identify template configuration blocks.
- Reverts the DocBlock identifier from
TM_SETTINGSback toDOMAIN_SETTINGSacross all files - Updates code comments, documentation, and examples to reflect the original naming
- Restores the regex pattern in TemplateParser.php to search for
DOMAIN_SETTINGS
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pages/settings.php | Reverts comments referencing the template settings identifier |
| pages/config.php | Reverts comment describing templates being retrieved |
| lib/TemplateParser.php | Reverts class documentation, method comments, inline comments, and regex pattern for DocBlock parsing |
| install/demo_template.php | Reverts the DocBlock identifier in the demo template |
| README.md | Reverts all documentation and code examples to use DOMAIN_SETTINGS |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #2