Update varnish-configuration.rst #183
Conversation
There was a problem hiding this comment.
not sure, the examples actually are constantly tested on travis-ci... but this is too much detail here, maybe we can just say that we provide configuration for version 3 and 4, without talking about testing at all. wdyt?
There was a problem hiding this comment.
That's a fair point; perhaps the wording: "the examples below are provided for Varnish 3 and 4." - would that suit?
There was a problem hiding this comment.
actually its not examples, but reference documentation. lets say:
... features provided by this library. The configuration is provided for Varnish 3 and 4.
There was a problem hiding this comment.
Sure, that works with me - thanks!
Justin Finkelstein
Technical Director
ilithium limited
http://uk.linkedin.com/in/justinfinkelstein/
On 10 April 2015 at 18:03, David Buchmann notifications@github.com wrote:
In doc/varnish-configuration.rst
#183 (comment)
:@@ -4,7 +4,7 @@ Varnish Configuration
Below you will find detailed Varnish configuration recommendations for the
-features provided by this library. The examples are tested with Varnish
+features provided by this library. These examples have been tested with Varnishactually its not examples, but reference documentation. lets say:
... features provided by this library. The configuration is provided for
Varnish 3 and 4.—
Reply to this email directly or view it on GitHub
https://github.com/FriendsOfSymfony/FOSHttpCache/pull/183/files#r28161786
.
|
thanks. pushed that change directly to master. |
2 participants
Corrected grammar in introductory paragraph