Skip to content

Update varnish-configuration.rst #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update varnish-configuration.rst #183

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/varnish-configuration.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Varnish Configuration
---------------------

Below you will find detailed Varnish configuration recommendations for the
features provided by this library. The examples are tested with Varnish
features provided by this library. These examples have been tested with Varnish
Copy link
Contributor

@dbu dbu Apr 10, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure, the examples actually are constantly tested on travis-ci... but this is too much detail here, maybe we can just say that we provide configuration for version 3 and 4, without talking about testing at all. wdyt?

Copy link
Author

@iamfinky iamfinky Apr 10, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a fair point; perhaps the wording: "the examples below are provided for Varnish 3 and 4." - would that suit?

Copy link
Contributor

@dbu dbu Apr 10, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually its not examples, but reference documentation. lets say:

... features provided by this library. The configuration is provided for Varnish 3 and 4.

Copy link
Author

@iamfinky iamfinky Apr 10, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, that works with me - thanks!

Justin Finkelstein
Technical Director
ilithium limited
http://uk.linkedin.com/in/justinfinkelstein/

On 10 April 2015 at 18:03, David Buchmann notifications@github.com wrote:

In doc/varnish-configuration.rst
#183 (comment)
:

@@ -4,7 +4,7 @@ Varnish Configuration

Below you will find detailed Varnish configuration recommendations for the
-features provided by this library. The examples are tested with Varnish
+features provided by this library. These examples have been tested with Varnish

actually its not examples, but reference documentation. lets say:

... features provided by this library. The configuration is provided for
Varnish 3 and 4.

—
Reply to this email directly or view it on GitHub
https://github.com/FriendsOfSymfony/FOSHttpCache/pull/183/files#r28161786
.

versions 3 and 4.

Basic Varnish Configuration
Expand Down