Fix HHVM on Travis by using FastCGI instead of built-in webserver

[ddeboer]

Tests are now fixed, but I hardcoded FastCGI port 9000 for now in WebServerListener. @dbu What do you think, should we remove HHVM from the WebServerListener as HHVM no longer has a built-in webserver? Or should we keep it in the listener and have it start the HHVM server on the CGI port? I think we need an extra PHPUnit constant, CGI_PORT or something similar, in the latter case.

This fixes #58.

[stof]

how is this class related to fixing the testsuite on HHVM ?

[ddeboer]

Whoops, that class is related to the varnishamd implementation I'm working on. Nice catch, Christophe!

[stof]

@ddeboer is it still a WIP or is it ready ?

[ddeboer]

Still WIP because of my question above:

Tests are now fixed, but I hardcoded FastCGI port 9000 for now in WebServerListener. @dbu What do you think, should we remove HHVM from the WebServerListener as HHVM no longer has a built-in webserver? Or should we keep it in the listener and have it start the HHVM server on the CGI port? I think we need an extra PHPUnit constant, CGI_PORT or something similar, in the latter case.

[stof]

IMO, it should not be in the WebServerListener anymore as starting the CGI is only half of the actual work (you would have to also start the actual webserver in the listener otherwise, which seems insane).

[dbu]

yeah lets not have it in the listener. we also don't try to start apache for 5.3 in that listener.

[ddeboer]

😉

[ddeboer]

😉

[ddeboer]

Ok, done. Have a look; this can be merged now.

[dbu]

thanks