cleaning up testing of varnish context hash #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Contributor
Author
|
/cc @joelwurtz do you want to have a look? i tried to split things up some more to make it more readable. the diff in github is exaggerated - i mostly just split files, did not change much code. |
Contributor
|
Yes better, sounds good for me. |
Contributor
There was a problem hiding this comment.
missing assertContextCache
Contributor
There was a problem hiding this comment.
Or maybe not, should be miss in both case :)
dbu
added a commit
that referenced
this pull request
May 24, 2014
cleaning up testing of varnish context hash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
went over #62 and tried to clean up the tests. the most important bit is that i wanted to get rid of the custom header by the test to control whether hash requests should be cached