Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/CacheInvalidator.php
Original file line number Diff line number Diff line change
Expand Up @@ -49,17 +49,17 @@ class CacheInvalidator
/**
* @var ProxyClientInterface
*/
protected $cache;
private $cache;

/**
* @var EventDispatcherInterface
*/
protected $eventDispatcher;
private $eventDispatcher;

/**
* @var string
*/
protected $tagsHeader = 'X-Cache-Tags';
private $tagsHeader = 'X-Cache-Tags';

/**
* Constructor
Expand Down
2 changes: 1 addition & 1 deletion src/Event.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

class Event extends BaseEvent
{
protected $exception;
private $exception;

/**
* Set exception
Expand Down
4 changes: 2 additions & 2 deletions src/EventListener/LogSubscriber.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class LogSubscriber implements EventSubscriberInterface
/**
* @var LoggerInterface
*/
protected $logger;
private $logger;

public function __construct(LoggerInterface $logger)
{
Expand Down Expand Up @@ -50,7 +50,7 @@ public function onProxyResponseError(Event $event)
$this->log(LogLevel::CRITICAL, $event->getException());
}

protected function log($level, \Exception $exception)
private function log($level, \Exception $exception)
{
$context = array(
'exception' => $exception
Expand Down
2 changes: 1 addition & 1 deletion src/Exception/ExceptionCollection.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
*/
class ExceptionCollection extends \Exception implements \IteratorAggregate, \Countable, HttpCacheExceptionInterface
{
protected $exceptions = array();
private $exceptions = array();

/**
* Add an exception to the collection
Expand Down
8 changes: 4 additions & 4 deletions src/ProxyClient/AbstractProxyClient.php
Original file line number Diff line number Diff line change
Expand Up @@ -34,21 +34,21 @@ abstract class AbstractProxyClient implements ProxyClientInterface
*
* @var array
*/
protected $servers;
private $servers;

/**
* HTTP client
*
* @var ClientInterface
*/
protected $client;
private $client;

/**
* Request queue
*
* @var array|RequestInterface[]
*/
protected $queue;
private $queue;

/**
* Constructor
Expand Down Expand Up @@ -156,7 +156,7 @@ protected function createRequest($method, $url, array $headers = array())
*
* @throws ExceptionCollection
*/
protected function sendRequests(array $requests)
private function sendRequests(array $requests)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this ok?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. If we go private, let's go private all the way. :)

{
$allRequests = array();

Expand Down
2 changes: 1 addition & 1 deletion src/ProxyClient/Nginx.php
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ class Nginx extends AbstractProxyClient implements PurgeInterface, RefreshInterf
*
* @var string|false
*/
protected $purgeLocation;
private $purgeLocation;

/**
* {@inheritdoc}
Expand Down
2 changes: 1 addition & 1 deletion src/ProxyClient/Varnish.php
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ class Varnish extends AbstractProxyClient implements BanInterface, PurgeInterfac
*
* @var array
*/
protected $defaultBanHeaders = array(
private $defaultBanHeaders = array(
self::HTTP_HEADER_HOST => self::REGEX_MATCH_ALL,
self::HTTP_HEADER_URL => self::REGEX_MATCH_ALL,
self::HTTP_HEADER_CONTENT_TYPE => self::REGEX_MATCH_ALL
Expand Down