trigger deprecation notices for deprecated code #282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
force-pushed
the
trigger-deprecations
branch
from
a997a10 to
8aa7a54
Compare
Contributor
Author
|
ah, found the thing about legacy tests. |
HttpCache.php
Outdated
|
|
||
| public function __construct(HttpKernelInterface $kernel, $cacheDir = null) | ||
| { | ||
| @trigger_error('The '.__CLASS__.' class is deprecated since version 1.2 and will be removed in 2.0. Use FOS\HttpCacheBundle\SymfonyCache\EventDispatchingHttpCache instead.', E_USER_DEPRECATED); |
Member
There was a problem hiding this comment.
When the whole class is deprecated, you could also put this above the class definition directly.
Member
|
If there won't be a 1.4 version (the next one is 2.0), then it should indeed make it into 1.3 |
dbu
force-pushed
the
trigger-deprecations
branch
from
8aa7a54 to
2e69cbe
Compare
HttpCache.php
Outdated
| use Symfony\Component\HttpFoundation\Request; | ||
| use Symfony\Component\HttpKernel\HttpKernelInterface; | ||
|
|
||
| @trigger_error('The '.__CLASS__.' class is deprecated since version 1.2 and will be removed in 2.0. Use FOS\HttpCacheBundle\SymfonyCache\EventDispatchingHttpCache instead.', E_USER_DEPRECATED); |
Member
There was a problem hiding this comment.
__CLASS__ is not defined outside of a class. Use something like this: https://github.com/symfony/symfony/blob/2.8/src/Symfony/Component/Form/Extension/Core/ChoiceList/ObjectChoiceList.php#L14
dbu
force-pushed
the
trigger-deprecations
branch
from
2e69cbe to
cb96b54
Compare
dbu
added a commit
that referenced
this pull request
Feb 18, 2016
trigger deprecation notices for deprecated code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #266
@Tobion am i correct that this should go into the 1.3 branch? we want to delete this things for 2.0 so the deprecations would not really help there. i don't want to build a 1.4 version only for the migration like symfony 2.8 is - too much effort.
also, do you know how to make the deprecations helper not complain about our legacy tests? i tried the
@legacyannotation on the test cases, but that did not seem help.