Patch release for a 1.5.4 release #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the development of google closure library has moved from Google Code to GitHub
Member
|
@weaverryan it is a bugfix |
Member
|
Ok, so the one screwing up the target of bug fixes is only me. Great to know this... |
Contributor
Author
|
@stof Nevermind, that sha you said is a bug fix IS a bug fix, but for a feature (class) that only exists on master. So, I think it is only these 2. ... and maybe it's just that you're the only one fixing bugs... and that there haven't been very many 🎆 |
Contributor
Author
|
@stof This is ready to go - it'll just need a merge and a tag. The build failures are the same that are on master - pretty sure they're unrelated. Thanks! |
stof
added a commit
that referenced
this pull request
Jan 23, 2015
Patch release for a 1.5.4 release
Member
|
I fixed the PHPUnit testsuite |
|
👍 |
Contributor
Author
|
tyvm :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #180.
From the commits since the last tag to master (1.5.3...master), I only identified 2 things that could be considered bug fixes (and one fixes a test, so it's not important).
@stof The only commit that maybe should also be included is sha: cd5229b. If that is indeed a bug fix, let me know and I'll patch it onto here.
The idea is that this will let us tag a new 1.5.4, which (primarily) has a bug fix for Symfony 2.6.
Thanks!