Symfony3 support (merged forks) #283
Conversation
Fix a typo in English
Add Czech translation
Fix a typo in translations
Symfony 3.0 stuff
… into ubermuda-symfony3 Conflicts: Controller/MessageController.php FormFactory/AbstractMessageFormFactory.php FormHandler/AbstractMessageFormHandler.php FormType/NewThreadMessageFormType.php FormType/RecipientsType.php Resources/config/form.xml Resources/config/spam_detection.xml Search/QueryFactory.php Security/ParticipantProvider.php
… into ubermuda-symfony3 Conflicts: Controller/MessageController.php FormFactory/AbstractMessageFormFactory.php FormHandler/AbstractMessageFormHandler.php FormType/NewThreadMessageFormType.php FormType/RecipientsType.php Resources/config/form.xml Resources/config/spam_detection.xml Search/QueryFactory.php Security/ParticipantProvider.php
|
That's an awesome work, I'll check this tonight! Thanks! |
|
Amazing work! Thanks for your efforts. |
|
Thanks for your work! Will this be merge? |
| ->children() | ||
| ->scalarNode('factory')->defaultValue('fos_message.new_thread_form.factory.default')->cannotBeEmpty()->end() | ||
| ->scalarNode('type')->defaultValue('fos_message.new_thread_form.type.default')->cannotBeEmpty()->end() | ||
| ->scalarNode('class')->defaultValue('FOS\MessageBundle\FormType\NewThreadMessageFormType')->cannotBeEmpty()->end() |
There was a problem hiding this comment.
this is clearly a bc break, we need a bc layer to keep supporting the old option
| public function __construct(RequestStack $requestStack, ComposerInterface $composer, SenderInterface $sender, ParticipantProviderInterface $participantProvider) | ||
| { | ||
| $this->request = $request; | ||
| $this->request = $requestStack->getCurrentRequest(); |
There was a problem hiding this comment.
The request must not be retrieved in the constructor.
You can do something like:
/**
* @param Request|RequestStack $request
*/
public function __construct($request, ...) {
if ($request instanceof Request) {
@trigger_error(sprintf('Using an instance of "%s" as first parameter of "%s" is deprecated since version 1.3 and won\'t be supported in 2.0. Use an instance of "Symfony\Component\HttpFoundation\RequestStack" instead.', get_class($request), __METHOD), E_USER_DEPRECATED);
}
$this->request = $request;
// ...
}
private function getCurrentRequest() {
if ($this->request instanceof Request) {
return $this->request;
}
return $this->request->getCurrentRequest();
}
public function process() {
// ...
$request = $this->getCurrentRequest();
}
|
BTW it looks like changes to |
|
@ownede are you still interested to work on this PR ? |
|
@Ener-Getick Well, this PR contains merges of various authors' forks. I'm still interested into further development, but it may take time. If somebody is also interested, please fell free to push your changes to my fork. btw. It seems to work fine with Symfony 3.0 on PHP 5.6, if anyone wants to use it before public release 😜 |
|
Take all the time you need :) Thanks for contributing to the open source community ! |
|
This should be fixed by #289, I close but if you have problems, don't hesitate to open an issue :) ! |
8 participants
Merged my, @ubermuda, @bassrock and @DenisMedved code together.
As mentioned in #275 basic features seems to be working, no more deprecated code.
Currently testing this on my project.
Thanks for anyone who contributed.