-
Notifications
You must be signed in to change notification settings - Fork 184
Symfony3 support (merged forks) #283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
c15f204
fix of deprecated functions
DenysMedvid 6c0d24a
fix deprecated security.context
DenysMedvid 5a5aaf0
Add Czech translation
dfridrich f502d35
Fix a typo
dfridrich e7e0ca5
Merge pull request #276 from dfridrich/patch-2
tgalopin e8f7956
Merge pull request #277 from dfridrich/patch-1
tgalopin fd2752f
Fixing deprecations
bassrock c78c9a7
Fix a typo
dfridrich f824ef8
Merge pull request #279 from dfridrich/patch-4
tgalopin cd4d911
Merge pull request #1 from Klinche/master
ownede e3a8d89
Merge pull request #2 from FriendsOfSymfony/symfony3
ownede ce904d7
Removed use of ContainerAware (removed in Symfony 3.0)
1837ca1
Update scoped services to use request_stack
ubermuda d0c3481
Update services to use token storage instead of security context
ubermuda f5843ea
Switch from ContainerAware to ContainerAwareInterface
ubermuda e367a88
Make container property protected in message controller
ubermuda b865d10
Update form factory configuration
ubermuda 946e99e
Update form handler to use handleRequest instead of bind
ubermuda 77bf522
Update forms to use new type declaration
ubermuda 0608251
Update forms to use configureOptions
ubermuda aa9eaf5
Merge branch 'symfony3' of https://github.com/ubermuda/FOSMessageBund…
c334607
Merge branch 'symfony3' of https://github.com/ubermuda/FOSMessageBund…
90912fc
Merge branch 'ubermuda-symfony3' into symfony3
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,7 +2,6 @@ | |
|
|
||
| namespace FOS\MessageBundle\FormFactory; | ||
|
|
||
| use Symfony\Component\Form\AbstractType; | ||
| use Symfony\Component\Form\FormFactoryInterface; | ||
| use FOS\MessageBundle\FormModel\AbstractMessage; | ||
|
|
||
|
|
@@ -21,11 +20,11 @@ abstract class AbstractMessageFormFactory | |
| protected $formFactory; | ||
|
|
||
| /** | ||
| * The message form type | ||
| * The message form class | ||
| * | ||
| * @var AbstractType | ||
| * @var string | ||
| */ | ||
| protected $formType; | ||
| protected $formClass; | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. that's a bc break as well |
||
|
|
||
| /** | ||
| * The name of the form | ||
|
|
@@ -41,10 +40,10 @@ abstract class AbstractMessageFormFactory | |
| */ | ||
| protected $messageClass; | ||
|
|
||
| public function __construct(FormFactoryInterface $formFactory, AbstractType $formType, $formName, $messageClass) | ||
| public function __construct(FormFactoryInterface $formFactory, $formClass, $formName, $messageClass) | ||
| { | ||
| $this->formFactory = $formFactory; | ||
| $this->formType = $formType; | ||
| $this->formClass = $formClass; | ||
| $this->formName = $formName; | ||
| $this->messageClass = $messageClass; | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is clearly a bc break, we need a bc layer to keep supporting the old option