Skip to content

Conversation

@thirsch
Copy link

@thirsch thirsch commented Feb 10, 2024

... and also removing the sponsor, as this is not the case for this fork.

@thirsch thirsch requested review from connorhu and thePanz February 11, 2024 18:49
@thePanz
Copy link
Member

thePanz commented Feb 11, 2024

Thanks @thirsch

Ps: Should we poke Blackfire for a OSS license? :)

@thePanz thePanz merged commit 097f263 into FriendsOfSymfony1:6.x Feb 11, 2024
@thirsch thirsch deleted the feature/updating-repo-readme branch February 11, 2024 19:52
@thirsch
Copy link
Author

thirsch commented Feb 11, 2024

Ps: Should we poke Blackfire for a OSS license? :)

I've never used Blackfire, not sure if it would help here?

@thePanz
Copy link
Member

thePanz commented Feb 11, 2024

Ps: Should we poke Blackfire for a OSS license? :)

I've never used Blackfire, not sure if it would help here?

Not 100% sure for this repo, true. But it helped me to identify memory leaks and bottlenecks in our code. (I presented it in a SF con talk last year ;-) )

Let's keep it in memory just in case we want to try it on the friendsofsynfony1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants