[TASK] Use SystemResourceFactory instead of deprecated functions#80
Merged
Conversation
Kanti
force-pushed
the
task/use-systemResourceFactory
branch
from
5717ed9 to
8468e0f
Compare
Use `SystemResourceFactory` in v14 instead of the deprecated `PathUtility::getPublicResourceWebPath` and `GeneralUtility::createVersionNumberedFilename`. We also add the comment `// @extensionScannerIgnoreLine` to mark the lines covered for the extension scanner. And add comment: `// TODO use DI if TYPO3 14 is the minimum requirement`
Kanti
force-pushed
the
task/use-systemResourceFactory
branch
from
8468e0f to
04daad0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
SystemResourceFactoryin v14 instead of the deprecatedPathUtility::getPublicResourceWebPathandGeneralUtility::createVersionNumberedFilename.