deps: bump the npm-dependencies group in /apps/vscode-extension with 5 updates#4
Closed
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps the npm-dependencies group in /apps/vscode-extension with 5 updates: | Package | From | To | | --- | --- | --- | | [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) | `22.19.19` | `25.9.1` | | [typescript-eslint](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/typescript-eslint) | `8.60.0` | `8.60.1` | | [eslint](https://github.com/eslint/eslint) | `9.39.4` | `10.4.1` | | [esbuild](https://github.com/evanw/esbuild) | `0.27.7` | `0.28.0` | | [typescript](https://github.com/microsoft/TypeScript) | `5.9.3` | `6.0.3` | Updates `@types/node` from 22.19.19 to 25.9.1 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) Updates `typescript-eslint` from 8.60.0 to 8.60.1 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/typescript-eslint/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.60.1/packages/typescript-eslint) Updates `eslint` from 9.39.4 to 10.4.1 - [Release notes](https://github.com/eslint/eslint/releases) - [Commits](eslint/eslint@v9.39.4...v10.4.1) Updates `esbuild` from 0.27.7 to 0.28.0 - [Release notes](https://github.com/evanw/esbuild/releases) - [Changelog](https://github.com/evanw/esbuild/blob/main/CHANGELOG.md) - [Commits](evanw/esbuild@v0.27.7...v0.28.0) Updates `typescript` from 5.9.3 to 6.0.3 - [Release notes](https://github.com/microsoft/TypeScript/releases) - [Commits](microsoft/TypeScript@v5.9.3...v6.0.3) --- updated-dependencies: - dependency-name: "@types/node" dependency-version: 25.9.1 dependency-type: direct:development update-type: version-update:semver-major dependency-group: npm-dependencies - dependency-name: typescript-eslint dependency-version: 8.60.1 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm-dependencies - dependency-name: eslint dependency-version: 10.4.1 dependency-type: direct:development update-type: version-update:semver-major dependency-group: npm-dependencies - dependency-name: esbuild dependency-version: 0.28.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm-dependencies - dependency-name: typescript dependency-version: 6.0.3 dependency-type: direct:development update-type: version-update:semver-major dependency-group: npm-dependencies ... Signed-off-by: dependabot[bot] <support@github.com>
📝 WalkthroughWalkthroughThe VSCode extension's ChangesDevelopment Dependencies
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/vscode-extension/package.json`:
- Around line 41-44: Add an engines.node guard to
apps/vscode-extension/package.json to prevent running ESLint v10 on unsupported
Node versions; update the top-level package.json object to include an "engines"
field (e.g., engines.node set to a minimum that satisfies ESLint v10 like
">=20.19.0") so local contributors and other runners are prevented from using
older Node runtimes when running tools like eslint, esbuild, npm-run-all, and
typescript.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: a93c1901-8b4b-47df-9a34-edc4c2c27b45
⛔ Files ignored due to path filters (1)
apps/vscode-extension/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
apps/vscode-extension/package.json
Comment on lines
+41
to
+44
| "eslint": "^10.4.1", | ||
| "esbuild": "^0.28.0", | ||
| "npm-run-all": "^4.1.5", | ||
| "typescript": "^5.9.3", | ||
| "typescript": "^6.0.3", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify whether Node version is constrained and whether CI/workflows pin a compatible Node.
# Expected: package.json has engines.node and workflows use node-version >= 20.19.
set -euo pipefail
echo "== package.json engines =="
jq '.engines' apps/vscode-extension/package.json
echo
echo "== workflow files with node-version =="
fd -i '.*\.ya?ml$' .github/workflows -x sh -c '
f="$1"
if rg -n "node-version|setup-node" "$f" >/dev/null; then
echo "--- $f"
rg -n "setup-node|node-version" "$f"
fi
' sh {}Repository: FrilLab/frilvault
Length of output: 356
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== node constraints in workspace (nvmrc/tool-versions) =="
ls -la .nvmrc .tool-versions 2>/dev/null || true
rg -n --hidden --glob '!.git/*' "node-version|setup-node|engines\" *:|\"node\"" .github/workflows package.json apps/vscode-extension/package.json 2>/dev/null || true
echo
echo "== all workflows with setup-node =="
fd -i '.*\.ya?ml$' .github/workflows -x sh -c '
f="$1"
if rg -n "actions/setup-node" "$f" >/dev/null; then
echo "--- $f"
rg -n "setup-node|node-version" "$f"
fi
' sh {}Repository: FrilLab/frilvault
Length of output: 657
🌐 Web query:
ESLint v10 minimum supported Node.js version
💡 Result:
ESLint v10 requires one of the following Node.js version ranges [1][2][3]: * Node.js ^20.19.0 * Node.js ^22.13.0 * Node.js >=24 These requirements were established with the release of ESLint v10.0.0 [1]. Projects must be running one of these specified versions or newer to use ESLint v10 [1][2].
Citations:
- 1: https://eslint.org/blog/2026/02/eslint-v10.0.0-released/
- 2: https://eslint.org/docs/latest/use/getting-started
- 3: https://www.npmjs.com/package/eslint
Add an engines.node guard for the ESLint v10 bump
CI already pins Node 22 for .github/workflows/ci.yml and .github/workflows/release.yml, but apps/vscode-extension/package.json lacks engines.node. With eslint v10, Node must satisfy ESLint’s supported ranges (e.g., ^20.19.0 / ^22.13.0), so adding a Node floor prevents local contributors/other runners from hitting toolchain failures.
Proposed change
"version": "0.0.1",
"engines": {
- "vscode": "^1.120.0"
+ "vscode": "^1.120.0",
+ "node": ">=20.19.0"
},🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@apps/vscode-extension/package.json` around lines 41 - 44, Add an engines.node
guard to apps/vscode-extension/package.json to prevent running ESLint v10 on
unsupported Node versions; update the top-level package.json object to include
an "engines" field (e.g., engines.node set to a minimum that satisfies ESLint
v10 like ">=20.19.0") so local contributors and other runners are prevented from
using older Node runtimes when running tools like eslint, esbuild, npm-run-all,
and typescript.
Contributor
Author
|
Looks like these dependencies are no longer updatable, so this is no longer needed. |
dependabot
Bot
deleted the
dependabot/npm_and_yarn/apps/vscode-extension/npm-dependencies-96415bd780
branch
Collaborator
|
#5 Solved in a full request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the npm-dependencies group in /apps/vscode-extension with 5 updates:
22.19.1925.9.18.60.08.60.19.39.410.4.10.27.70.28.05.9.36.0.3Updates
@types/nodefrom 22.19.19 to 25.9.1Commits
Updates
typescript-eslintfrom 8.60.0 to 8.60.1Release notes
Sourced from typescript-eslint's releases.
Changelog
Sourced from typescript-eslint's changelog.
Commits
4f84a69chore(release): publish 8.60.11849b53chore: typecheck using tsgo (#12139)Updates
eslintfrom 9.39.4 to 10.4.1Release notes
Sourced from eslint's releases.
... (truncated)
Commits
4a3d15a10.4.143e7e2bBuild: changelog update for 10.4.1e557467fix: update@eslint/plugin-kitversion to 0.7.2 (#20930)b0e466btest: adddataproperty to invalid tests cases for rules (#20924)d4ce898fix: propagate failures from delegated commands (#20917)f4f3507fix: prefer-arrow-callback invalid autofix with newline afterasync(#20916)f78838btest: add CodePath type coverage (#20904)61b0adddocs: remove deprecated rule from related rules ofmax-params(#20921)1daa4bdchore: updateeslint-plugin-eslint-commentstest data to latest commit (#20...002942cci: declare contents:read on update-readme workflow (#20919)Updates
esbuildfrom 0.27.7 to 0.28.0Release notes
Sourced from esbuild's releases.
Changelog
Sourced from esbuild's changelog.
Commits
6a794dfpublish 0.28.0 to npm64ee0eafix #4435: supportwith { type: text }importsef65aeefix sort order insnapshots_packagejson.txt1a26a8etry to fixtest-old-ts, also shuffle CI tasks556ce6cuse''instead ofnullto omit build hashes8e675a8ci: allow missing binary hashes for tests7067763Reapply "update go 1.25.7 => 1.26.1"39473a9fix #4343: integrity check for binary downloadUpdates
typescriptfrom 5.9.3 to 6.0.3Release notes
Sourced from typescript's releases.
Commits
050880cBump version to 6.0.3 and LKGeeae9dd🤖 Pick PR #63401 (Also check package name validity in...) into release-6.0 (#...ad1c695🤖 Pick PR #63368 (Harden ATA package name filtering) into release-6.0 (#63372)0725fb4🤖 Pick PR #63310 (Mark class property initializers as...) into release-6.0 (#...607a22aBump version to 6.0.2 and LKG9e72ab7🤖 Pick PR #63239 (Fix missing lib files in reused pro...) into release-6.0 (#...35ff23d🤖 Pick PR #63163 (Port anyFunctionType subtype fix an...) into release-6.0 (#...e175b69Bump version to 6.0.1-rc and LKGaf4caacUpdate LKG8efd7e8Merge remote-tracking branch 'origin/main' into release-6.0Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditionsSummary by CodeRabbit