Skip to content

Clean/cicd#1

Merged
will-fawcett-trillium merged 26 commits intomainfrom
clean/cicd
May 1, 2026
Merged

Clean/cicd#1
will-fawcett-trillium merged 26 commits intomainfrom
clean/cicd

Conversation

@r-spiewak
Copy link
Copy Markdown
Collaborator

Add CI/CD and clean codebase

@r-spiewak r-spiewak self-assigned this Apr 6, 2026
@will-fawcett-trillium will-fawcett-trillium self-requested a review April 7, 2026 12:44
@will-fawcett-trillium
Copy link
Copy Markdown
Contributor

will-fawcett-trillium commented Apr 8, 2026

Fixed

  • Removed stale .pylintrc pathsper-file-ignores referenced src/stars/ paths from another project
  • Replaced custom EveApiResponse enum with stdlib http.HTTPStatus — removes a custom abstraction that duplicated Python's built-in IntEnum for HTTP status codes, eliminates .value calls at every usage site
  • Bumped coverage threshold from 5% to 80% — industry standard minimum
  • CI: Python version matrix (3.11, 3.12, 3.13) — replaces single pinned 3.12.11, uses minor versions so CI picks up
    patch releases automatically
  • CI: Added dependency caching — speeds up CI runs by caching the Poetry virtualenv
  • Bumped minimum Python from 3.10 to 3.11 — 3.10 reaches EOL Oct 2026, aligns with CI matrix. Regenerated poetry.lock to drop 3.10 backport dependencies (exceptiongroup, backports-asyncio-runner, tomli)
  • Fixed make_auth() test helper — uses real EVEAuth constructor instead of __new__ bypass, so tests break correctly if __init__ changes
  • Fixed misleading test nametest_response_invalid_json_raises_api_error renamed to
    test_response_missing_detail_raises_api_error to match what it actually tests
  • Renamed random_error variables — replaced with unprocessable_entity (422) and unknown_error (452) for clarity

  - Remove commented-out hatch/ruff config
  - Fix repository URL to FrontierDevelopmentLab/eve-api
  - Update black target-version to py312
  - Simplify coverage source to just src/ (tests were included then omitted)
  - Remove unused type stubs (types-requests, types-toml)
  - Regenerate poetry.lock
will-fawcett and others added 3 commits April 30, 2026 09:40
NotFoundError previously required (resource, resource_id) and the
404 branch in _handle_error passed hardcoded ("resource", "unknown"),
discarding the parsed `detail` from the response body. Switch the
constructor to accept a message + details (matching the other APIError
subclasses) and forward the parsed message through.
…-and-rough-edges

Improvements readme and rough edges
Copy link
Copy Markdown
Collaborator Author

@r-spiewak r-spiewak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd mark this as "request changes", but apparently since I opened the PR I can neither do that nor approve.

Comment thread src/eve_api/client.py Outdated
Comment thread tests/test_auth.py Outdated
Comment thread tests/test_auth.py Outdated
Comment thread tests/test_client.py Outdated
Comment thread tests/test_client.py
Comment thread tests/test_client.py Outdated
Comment thread .pre-commit-config.yaml Outdated
Comment thread pyproject.toml Outdated
Copy link
Copy Markdown
Collaborator Author

@r-spiewak r-spiewak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor change request, and an interesting observation.

Comment thread tests/test_client.py
Comment thread tests/test_client.py
@will-fawcett-trillium will-fawcett-trillium merged commit 4ecfb41 into main May 1, 2026
4 checks passed
@will-fawcett-trillium will-fawcett-trillium deleted the clean/cicd branch May 1, 2026 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants