cleanup: remove EVEMCPClient and expand README for v0.0.1#3
Merged
will-fawcett-trillium merged 3 commits intomainfrom Apr 28, 2026
Merged
cleanup: remove EVEMCPClient and expand README for v0.0.1#3will-fawcett-trillium merged 3 commits intomainfrom
will-fawcett-trillium merged 3 commits intomainfrom
Conversation
Per collaborator guidance for v0.0.1, the in-tree MCP client demo is not the right way to consume an MCP server: it spawns the server itself as a subprocess and shipping it from the package's public API mis-signals that pattern as endorsed. Real hosts (Claude Desktop, Cursor, Claude Code, etc.) launch the server themselves via their own config. Also trim config.py to just SERVER_MODULE; PYTHON_BIN / PYTHON_PATH existed only to feed the removed StdioServerParameters call. Tests still import SERVER_MODULE. Can be reintroduced later under examples/ alongside correct usage.
Replace the one-line stub with: alpha/WIP banner, the list of MCP tools the server registers, install instructions (including submodule init), env var table for EVE_EMAIL / EVE_PASSWORD / EVE_BASE_URL, the stdio run command, and pre-commit setup. Addresses the v0.0.1 README ask from the collaborator's release checklist.
4 tasks
Attribute copyright to Trillium Technologies Ltd, 2026.
3 tasks
r-spiewak
approved these changes
Apr 28, 2026
Collaborator
r-spiewak
left a comment
r-spiewak
left a comment
There was a problem hiding this comment.
Looks good. One (optional) minor suggestion.
| submodule for the upstream `eve-api` client. | ||
|
|
||
| ```bash | ||
| git clone --recurse-submodules https://github.com/<org>/eve-mcp.git |
Collaborator
There was a problem hiding this comment.
Suggested change
| git clone --recurse-submodules https://github.com/<org>/eve-mcp.git | |
| git clone --recurse-submodules https://github.com/FrontierDevelopmentLab/eve-mcp.git |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/eve_mcp/client.py(EVEMCPClient) and its placeholdertests/test_client.py. Per the v0.0.1 release checklist, the in-tree client is not the right way to consume an MCP server — it spawns the server itself as a subprocess and shipping it from the package's public API mis-signals that pattern as endorsed.src/eve_mcp/config.pyto justSERVER_MODULE.PYTHON_BINandPYTHON_PATHexisted only to feed the removedStdioServerParameterscall; tests still importSERVER_MODULE.README.mdfrom a one-line stub into install / config / run / dev sections, with an alpha/WIP banner and the list of MCP tools the server registers.Stacks on top of #2 (
clean/cicd). Will retarget tomainonce #2 merges.A correct client example can be reintroduced later under
examples/alongside hosts that drive the server the canonical way.Test plan
poetry run pre-commit run --all-files— all hooks passpoetry run python -m eve_mcp.serverboots over stdio