-
Notifications
You must be signed in to change notification settings - Fork 4
chore: fix css and js filename exchanged #668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
julianiff
commented
Jan 8, 2024
- js and css hashed filename was switched.
🦋 Changeset detectedLatest commit: dca1723 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
SamuelAlev
approved these changes
Jan 8, 2024
|
Merged
SamuelAlev
added a commit
that referenced
this pull request
Jan 10, 2024
* feat: add manifest verification for Platform Apps (#645) * chore: add method stub * chore: add manifest stub * feat: add platform-app manifest validator step * Create curvy-terms-watch.md * fix: formatting * fix: remove yup and add zod schema * Update .changeset/curvy-terms-watch.md Co-authored-by: Samuel Alev <samuel.alev@frontify.com> * chore: remove verify-manifest cli command * fix: manifest keys * fix: add check to restrict version to be a number * fix: restructure manifest readout and throw Error if not correct * fix: adjust casing and wording of manifest * Update packages/cli/src/utils/verifyManifest.ts Co-authored-by: Samuel Alev <samuel.alev@frontify.com> * Update packages/cli/src/utils/verifyManifest.ts Co-authored-by: Samuel Alev <samuel.alev@frontify.com> * Update packages/cli/src/utils/verifyManifest.ts Co-authored-by: Samuel Alev <samuel.alev@frontify.com> * chore: object destructure the manifest * chore: fix typo * chore: add z.enums instead string where applicable * chore: formatting * chore: remove useless refine and add cleaner objects --------- Co-authored-by: Samuel Alev <samuel.alev@frontify.com> * chore: release packages (#658) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * feat: themes and template settings (#654) * themeAsset updates * types * typing * update tests * code smell fix * more code small * more code smell * fix test * typing fixes * updates * fix typing error * refactor: improve typing * style: linting --------- Co-authored-by: Mike Trummer <mike.trummer@frontify.com> * chore: add changeset for previous commit * chore: release packages (#660) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix: fix links in readme (#661) * fix: platform app compiler (#664) * chore: adjust compiler * Create unlucky-mice-give.md * chore: release packages (#665) Co-authored-by: julianiff <julian.iff@frontify.com> * revert: wrong release * chore: release packages (#667) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * chore: fix css and js filename exchanged (#668) * chore: fix css and js filename exchanged * Create spicy-apricots-guess.md * chore: release packages (#669) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * chore: add optional to assetAction (#670) * chore: add optional to assetAction * Create olive-goats-nail.md * chore: change naming to workspace (#673) * chore: change naming to workspace * Create small-kiwis-tap.md * chore: update platform app manifest (#674) * chore: update manfiest * Create gorgeous-baboons-run.md * Update .changeset/gorgeous-baboons-run.md Co-authored-by: Samuel Alev <samuel.alev@frontify.com> * lint: fixing --------- Co-authored-by: Samuel Alev <samuel.alev@frontify.com> * chore: release packages (#671) Co-authored-by: julianiff <julian.iff@frontify.com> --------- Co-authored-by: Julian Iff <julian.iff@frontify.com> Co-authored-by: Samuel Alev <samuel.alev@frontify.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Anxo Botana <angel.botana@frontify.com> Co-authored-by: Mike Trummer <mike.trummer@frontify.com> Co-authored-by: Luca Hochreutener <34413733+hochreutenerl@users.noreply.github.com>
ragi96
pushed a commit
that referenced
this pull request
Jan 22, 2024
* chore: fix css and js filename exchanged * Create spicy-apricots-guess.md
ragi96
added a commit
that referenced
this pull request
Jan 22, 2024
* feat: add manifest verification for Platform Apps (#645) * chore: add method stub * chore: add manifest stub * feat: add platform-app manifest validator step * Create curvy-terms-watch.md * fix: formatting * fix: remove yup and add zod schema * Update .changeset/curvy-terms-watch.md Co-authored-by: Samuel Alev <samuel.alev@frontify.com> * chore: remove verify-manifest cli command * fix: manifest keys * fix: add check to restrict version to be a number * fix: restructure manifest readout and throw Error if not correct * fix: adjust casing and wording of manifest * Update packages/cli/src/utils/verifyManifest.ts Co-authored-by: Samuel Alev <samuel.alev@frontify.com> * Update packages/cli/src/utils/verifyManifest.ts Co-authored-by: Samuel Alev <samuel.alev@frontify.com> * Update packages/cli/src/utils/verifyManifest.ts Co-authored-by: Samuel Alev <samuel.alev@frontify.com> * chore: object destructure the manifest * chore: fix typo * chore: add z.enums instead string where applicable * chore: formatting * chore: remove useless refine and add cleaner objects --------- Co-authored-by: Samuel Alev <samuel.alev@frontify.com> * chore: release packages (#658) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * feat: themes and template settings (#654) * themeAsset updates * types * typing * update tests * code smell fix * more code small * more code smell * fix test * typing fixes * updates * fix typing error * refactor: improve typing * style: linting --------- Co-authored-by: Mike Trummer <mike.trummer@frontify.com> * chore: add changeset for previous commit * chore: release packages (#660) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix: fix links in readme (#661) * fix: platform app compiler (#664) * chore: adjust compiler * Create unlucky-mice-give.md * chore: release packages (#665) Co-authored-by: julianiff <julian.iff@frontify.com> * revert: wrong release * chore: release packages (#667) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * chore: fix css and js filename exchanged (#668) * chore: fix css and js filename exchanged * Create spicy-apricots-guess.md * chore: release packages (#669) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * chore: add optional to assetAction (#670) * chore: add optional to assetAction * Create olive-goats-nail.md * chore: change naming to workspace (#673) * chore: change naming to workspace * Create small-kiwis-tap.md * chore: update platform app manifest (#674) * chore: update manfiest * Create gorgeous-baboons-run.md * Update .changeset/gorgeous-baboons-run.md Co-authored-by: Samuel Alev <samuel.alev@frontify.com> * lint: fixing --------- Co-authored-by: Samuel Alev <samuel.alev@frontify.com> * chore: release packages (#671) Co-authored-by: julianiff <julian.iff@frontify.com> --------- Co-authored-by: Julian Iff <julian.iff@frontify.com> Co-authored-by: Samuel Alev <samuel.alev@frontify.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Anxo Botana <angel.botana@frontify.com> Co-authored-by: Mike Trummer <mike.trummer@frontify.com> Co-authored-by: Luca Hochreutener <34413733+hochreutenerl@users.noreply.github.com>
SamuelAlev
added a commit
that referenced
this pull request
Jan 22, 2024
* feat: add manifest verification for Platform Apps (#645) * chore: add method stub * chore: add manifest stub * feat: add platform-app manifest validator step * Create curvy-terms-watch.md * fix: formatting * fix: remove yup and add zod schema * Update .changeset/curvy-terms-watch.md Co-authored-by: Samuel Alev <samuel.alev@frontify.com> * chore: remove verify-manifest cli command * fix: manifest keys * fix: add check to restrict version to be a number * fix: restructure manifest readout and throw Error if not correct * fix: adjust casing and wording of manifest * Update packages/cli/src/utils/verifyManifest.ts Co-authored-by: Samuel Alev <samuel.alev@frontify.com> * Update packages/cli/src/utils/verifyManifest.ts Co-authored-by: Samuel Alev <samuel.alev@frontify.com> * Update packages/cli/src/utils/verifyManifest.ts Co-authored-by: Samuel Alev <samuel.alev@frontify.com> * chore: object destructure the manifest * chore: fix typo * chore: add z.enums instead string where applicable * chore: formatting * chore: remove useless refine and add cleaner objects --------- Co-authored-by: Samuel Alev <samuel.alev@frontify.com> * chore: release packages (#658) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * feat: themes and template settings (#654) * themeAsset updates * types * typing * update tests * code smell fix * more code small * more code smell * fix test * typing fixes * updates * fix typing error * refactor: improve typing * style: linting --------- Co-authored-by: Mike Trummer <mike.trummer@frontify.com> * chore: add changeset for previous commit * chore: release packages (#660) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix: fix links in readme (#661) * fix: platform app compiler (#664) * chore: adjust compiler * Create unlucky-mice-give.md * chore: release packages (#665) Co-authored-by: julianiff <julian.iff@frontify.com> * revert: wrong release * chore: release packages (#667) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * chore: fix css and js filename exchanged (#668) * chore: fix css and js filename exchanged * Create spicy-apricots-guess.md * chore: release packages (#669) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * chore: add optional to assetAction (#670) * chore: add optional to assetAction * Create olive-goats-nail.md * chore: change naming to workspace (#673) * chore: change naming to workspace * Create small-kiwis-tap.md * chore: update platform app manifest (#674) * chore: update manfiest * Create gorgeous-baboons-run.md * Update .changeset/gorgeous-baboons-run.md Co-authored-by: Samuel Alev <samuel.alev@frontify.com> * lint: fixing --------- Co-authored-by: Samuel Alev <samuel.alev@frontify.com> * chore: release packages (#671) Co-authored-by: julianiff <julian.iff@frontify.com> * chore: update cli version of templates (#676) * chore: update version * Create giant-eels-fix.md * chore: add cypress videos and screenshots to .gitignore (#681) * feat: replace attachment download with tracked download (#679) * feat: replace attachment download with tracked download * add changeset * fix: download optional on AttachmentItem * improve syntax * chore: change download prop to onDownload * feat: update block toolbar to include attachments flyout (#672) * update toolbar with attachments flyout * rename prop to isEnabled * update classnames * move grouped elements into subfolder * update regular attachment button * remove bg base class * create tests for new function * fix toolbar * add changeset * update useAttachments * remove fc * add test for hoc * fix typeerror * fix issues * update changelog * fix minor issues * update naming of add method * update changelog * fix failing test * update string error description * fix: typeerror in toolbar (#683) * chore: release packages (#677) Signed-off-by: Sam Creasey <sam.creasey@frontify.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * ci: add linting and typecheck to guideline-blocks-settings (#685) * ci: add linting and typecheck to guideline-blocks-settings * add change in guideline block settings to check * add typeerror -> see fail * revert: changes so only ci * chore: remove usage of deprecated appBridgeBlock functions (#680) * chore: remove usage of deprecated appBridgeBlock functions * test: improve LegacyTemplateDummy import * test: improve LegacyTemplateDummy import * fix: add unsubscribe to assetChooser and templateChooser hook * ci: add unit test check guideline-blocks-settings (#690) * ci: add unit test check * fix: force line height in toolbar (#692) * force line-height in toolbar * add changeset * update changeset * update text * fix: export toolbar items (#691) * export index * add changeset * chore: release packages (#686) Signed-off-by: Sam Creasey <sam.creasey@frontify.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * feat(Attachments): temporarily disable sorting (#689) * feat(Attachments): temporarily disable sorting * chore: replace deprecated functions in attachments (#687) * chore: replace deprecated functions in attachments * fix: remove unused import * fix: add forced line height to button (#696) * add forced line height to button * correct changeset * chore: decouple sidebar-settings from app-bridge (#694) * chore: decouple sidebar-settings from app-bridge * fix: lockfile * add changeset * ci: add typecheck and remove app-bridge build * chore: bump fondue (#695) * chore: bump fondue * also bump outside of packages * chore: release packages (#693) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * chore: codeowners file (#699) * chore: bump fondue (#697) * chore: bump fondue * Create mean-lizards-draw.md * Update mean-lizards-draw.md --------- Co-authored-by: Rafael Giezendanner <rafael.giezendanner@frontify.com> * feat: move app-bridge to guideline-blocks-settings peerDependencies (#698) * chore: move app-bridge to peerDeps * ci: add test matrix * ci: build if workspace package * ci: add matrix on all guideline-blocks-test * fix: test for v3.0.0 * ci: add guideline-blocks-settings check to app-bridge * ci: improve pnpm cache * ci: replace set-output * test: rename hook in app-bridge to see them fail * revert: app-bridge change * add changeset * chore: update README.md * fix: typo in readme * Update .github/workflows/app-bridge-continuous-integration.yml Co-authored-by: Samuel Alev <samuel.alev@frontify.com> * ci: fix continous-deployment as it needs to add app-bridge to guideline-blocks-settings --------- Co-authored-by: Samuel Alev <samuel.alev@frontify.com> * fix: continuous-deployment ci (#702) * ci: add cache for app-bridge tests (#703) * ci: add cache for app-bridge tests * check: if it runs * revert: adjust for check * chore: release packages (#700) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> --------- Signed-off-by: Sam Creasey <sam.creasey@frontify.com> Co-authored-by: Julian Iff <julian.iff@frontify.com> Co-authored-by: Samuel Alev <samuel.alev@frontify.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Anxo Botana <angel.botana@frontify.com> Co-authored-by: Mike Trummer <mike.trummer@frontify.com> Co-authored-by: Luca Hochreutener <34413733+hochreutenerl@users.noreply.github.com> Co-authored-by: Sam Creasey <sam.creasey@frontify.com> Co-authored-by: Daniel Fulop <daniel.fulop@frontify.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
