refactor: link selector pass functions #736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 486a40a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
fulopdaniel
reviewed
Feb 8, 2024
fulopdaniel
reviewed
Feb 9, 2024
packages/guideline-blocks-settings/src/components/Link/LinkSelector/DocumentLinks.tsx
Outdated
Show resolved
Hide resolved
fulopdaniel
approved these changes
Feb 9, 2024
Merged
ragi96
added a commit
that referenced
this pull request
Feb 14, 2024
) * refactor: link selector pass functions (#736) * refactor: link selector not passing appBridge * get rid of hook * add changeset * fix: instance error * improve syntax * remove useless call * chore: release packages (#745) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * chore: update tailwind to 3.4.1 (#747) * update tailwind to 3.4.1 * Add changeset * Update .changeset/brown-carpets-matter.md Co-authored-by: Rafael Giezendanner <rafael.giezendanner@frontify.com> --------- Co-authored-by: Rafael Giezendanner <rafael.giezendanner@frontify.com> * feat: adjust serve and compile command (#732) * feat: adjust serve and compile command * Create fresh-ducks-dance.md * chore: adjust for comments * chore: add configFile: false to serve * chore: remove unused import * chore: remove logger * chore: remove generating a lib * Update packages/cli/src/utils/compiler.ts Co-authored-by: Samuel Alev <samuel.alev@frontify.com> * Update packages/cli/src/commands/serve.ts Co-authored-by: Samuel Alev <samuel.alev@frontify.com> * chore: remove globals * chore: remove build step * feat: add new template structure * feat: adjust platform-app templates * feat: add multiple build steps with temporary directory to store settings * feat: use index.ts file to create settings bundle * chore: update temaplte html * chore: update templates with defineApp * chore: use sync cals * chore: adjust templates * chore: update packages * chore: update tempaltes with external settings.ts * chore: add emptyOutDir to false and remove cleanup code * chore: remove function variable and adjust output dir of first pass * compiler.ts aktualisieren * chore: update to iife format * chore: fix linter and rename settings output file * feat: adjust tests and settings.js bundle --------- Co-authored-by: Samuel Alev <samuel.alev@frontify.com> * feat: use setAssetIdsByBlockAssetKey for updating assets (#730) * feat: use setAssetIdsByBlockAssetKey for updating assets * test: add stub for setAssetIdsByBlockAssetKey * refactor: stub and improve tests * improve hook * chore: add Changeset * fix: response type * Update .changeset/spicy-crabs-hope.md --------- Co-authored-by: ragi96 <rafael.giezendanner@frontify.com> Co-authored-by: Daniel Fulop <daniel.fulop@frontify.com> * chore: release packages (#748) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Sam Creasey <sam.creasey@frontify.com> Co-authored-by: Julian Iff <julian.iff@frontify.com> Co-authored-by: Samuel Alev <samuel.alev@frontify.com> Co-authored-by: Luca Hochreutener <34413733+hochreutenerl@users.noreply.github.com> Co-authored-by: Daniel Fulop <daniel.fulop@frontify.com>
ragi96
added a commit
that referenced
this pull request
Feb 16, 2024
* refactor: link selector pass functions (#736) * refactor: link selector not passing appBridge * get rid of hook * add changeset * fix: instance error * improve syntax * remove useless call * chore: release packages (#745) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * chore: update tailwind to 3.4.1 (#747) * update tailwind to 3.4.1 * Add changeset * Update .changeset/brown-carpets-matter.md Co-authored-by: Rafael Giezendanner <rafael.giezendanner@frontify.com> --------- Co-authored-by: Rafael Giezendanner <rafael.giezendanner@frontify.com> * feat: adjust serve and compile command (#732) * feat: adjust serve and compile command * Create fresh-ducks-dance.md * chore: adjust for comments * chore: add configFile: false to serve * chore: remove unused import * chore: remove logger * chore: remove generating a lib * Update packages/cli/src/utils/compiler.ts Co-authored-by: Samuel Alev <samuel.alev@frontify.com> * Update packages/cli/src/commands/serve.ts Co-authored-by: Samuel Alev <samuel.alev@frontify.com> * chore: remove globals * chore: remove build step * feat: add new template structure * feat: adjust platform-app templates * feat: add multiple build steps with temporary directory to store settings * feat: use index.ts file to create settings bundle * chore: update temaplte html * chore: update templates with defineApp * chore: use sync cals * chore: adjust templates * chore: update packages * chore: update tempaltes with external settings.ts * chore: add emptyOutDir to false and remove cleanup code * chore: remove function variable and adjust output dir of first pass * compiler.ts aktualisieren * chore: update to iife format * chore: fix linter and rename settings output file * feat: adjust tests and settings.js bundle --------- Co-authored-by: Samuel Alev <samuel.alev@frontify.com> * feat: use setAssetIdsByBlockAssetKey for updating assets (#730) * feat: use setAssetIdsByBlockAssetKey for updating assets * test: add stub for setAssetIdsByBlockAssetKey * refactor: stub and improve tests * improve hook * chore: add Changeset * fix: response type * Update .changeset/spicy-crabs-hope.md --------- Co-authored-by: ragi96 <rafael.giezendanner@frontify.com> Co-authored-by: Daniel Fulop <daniel.fulop@frontify.com> * chore: release packages (#748) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * refactor(guideline-blocks-settings): split toolbar into subcomponents (#749) * add base component buttons * make drag button * add typings for tooltip button * create menutoolbarbutton * restructure files * add single context for toolbar flyouts * move attachments toolbar button into folder * restructure to remove unrelated items from button folder * fix bugs * restructure files * rename flyout provider * swap with provider * update changelog * remove has * update changelog * fix failing spec * fix typeerror * remove unused class * update drag preview context * add footer props to flyout button * rename hook * Add testId attribute * Add wrappers for context * prepare elements for tests * fix failing test * fix failing test * fix typo * provide migration example * adjust md * change type children to content * test: toolbar components (#752) * test toolbar items * add spacing * update test branch * update tests * Update .changeset/cool-planets-decide.md Co-authored-by: Rafael Giezendanner <rafael.giezendanner@frontify.com> * Update .changeset/cool-planets-decide.md Co-authored-by: Rafael Giezendanner <rafael.giezendanner@frontify.com> --------- Co-authored-by: Rafael Giezendanner <rafael.giezendanner@frontify.com> * feat(Attachments): allow sorting (#757) * feat(Attachments): allow sorting * feat: support new v4 color type (#744) * unfinished first draft of adding support * feat: support new v4 color type * add changeset * rename isNewColor to isV4Color * fix: improve code * fix: adjust to new format * fix: adjust mapper for v4 * fix: review stuff * fix: typecheck * chore: release packages (#755) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix changelog * fix changelog * fix: changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to decouple the linkSelector further from the appBridge, we will pass the functions and not the appBridge itself
CU-8693rnyhk