Skip to content

feat(Dialog): dismissable prop#2685

Merged
SamuelAlev merged 6 commits intomainfrom
feat/dialog-dismissable-prop
Apr 10, 2026
Merged

feat(Dialog): dismissable prop#2685
SamuelAlev merged 6 commits intomainfrom
feat/dialog-dismissable-prop

Conversation

@LeoBakerHytch
Copy link
Copy Markdown
Contributor

🎯 What does this PR do?

Adds a (default true) dismissable prop to Dialog.Root. When set to false, this prevents the dialog from closing via Escape key press or clicking the underlay.

Screen Recording 2026-04-10 at 15 16 31

@LeoBakerHytch LeoBakerHytch requested a review from a team as a code owner April 10, 2026 13:20
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 10, 2026

🦋 Changeset detected

Latest commit: d2014dc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@frontify/fondue-components Minor
@frontify/fondue Patch
@frontify/fondue-rte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 10, 2026

Deploy Preview for fondue-components ready!

Name Link
🔨 Latest commit d2014dc
🔍 Latest deploy log https://app.netlify.com/projects/fondue-components/deploys/69d8fe1062609900086fb82c
😎 Deploy Preview https://deploy-preview-2685.components.fondue-components.frontify.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@SamuelAlev SamuelAlev merged commit 653ee58 into main Apr 10, 2026
12 checks passed
@SamuelAlev SamuelAlev deleted the feat/dialog-dismissable-prop branch April 10, 2026 14:05
@github-actions
Copy link
Copy Markdown
Contributor

Lead time: 1 hours, 20 minutes, 10 seconds (1.34 total hours) from first commit to close.
Review time: 45 minutes, 34 seconds (0.76 total hours) from ready for review to close.

  • First commit: 10.4.2026, 14:45:41.
  • Ready for review: 10.4.2026, 15:20:17.
  • Closed: 10.4.2026, 16:05:51.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants