Skip to content

feat: add onNavigate to card for tracking purposes#2688

Merged
mnoleto merged 2 commits intomainfrom
feat/card-on-navigate-for-tracking
Apr 15, 2026
Merged

feat: add onNavigate to card for tracking purposes#2688
mnoleto merged 2 commits intomainfrom
feat/card-on-navigate-for-tracking

Conversation

@mnoleto
Copy link
Copy Markdown
Contributor

@mnoleto mnoleto commented Apr 15, 2026

  • Added onNavigate?: MouseEventHandler to the interactive variant of CardRootProps
  • Added onNavigate?: never to the non-interactive variant (discriminated-union completeness)
  • Wired into handleLinkClick — fires before navigation, respects event.preventDefault() so consumers can cancel

CU-869cvg2mu

@mnoleto mnoleto requested a review from SamuelAlev April 15, 2026 09:19
@mnoleto mnoleto requested a review from a team as a code owner April 15, 2026 09:19
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 15, 2026

🦋 Changeset detected

Latest commit: 1c254a2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@frontify/fondue-components Minor
@frontify/fondue Patch
@frontify/fondue-rte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 15, 2026

Deploy Preview for fondue-components ready!

Name Link
🔨 Latest commit 1c254a2
🔍 Latest deploy log https://app.netlify.com/projects/fondue-components/deploys/69df58e1828cfa00089c045e
😎 Deploy Preview https://deploy-preview-2688.components.fondue-components.frontify.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mnoleto mnoleto enabled auto-merge (squash) April 15, 2026 09:21
@mnoleto mnoleto merged commit 371c67a into main Apr 15, 2026
12 checks passed
@mnoleto mnoleto deleted the feat/card-on-navigate-for-tracking branch April 15, 2026 09:34
@github-actions
Copy link
Copy Markdown
Contributor

Lead time: 15 minutes, 51 seconds (0.26 total hours) from first commit to close.
Review time: 14 minutes, 31 seconds (0.24 total hours) from ready for review to close.

  • First commit: 15.4.2026, 11:18:15.
  • Ready for review: 15.4.2026, 11:19:35.
  • Closed: 15.4.2026, 11:34:06.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants