fix(OrderableList): not ordering when dragging and dropping#2695
Merged
SamuelAlev merged 3 commits intomainfrom Apr 23, 2026
Merged
fix(OrderableList): not ordering when dragging and dropping#2695SamuelAlev merged 3 commits intomainfrom
OrderableList): not ordering when dragging and dropping#2695SamuelAlev merged 3 commits intomainfrom
Conversation
…uplicate instances
🦋 Changeset detectedLatest commit: 8241058 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for fondue-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
jcosta33
changed the title
OrderableList): not ordering when dragging and dropping
SamuelAlev
reviewed
Apr 23, 2026
SamuelAlev
approved these changes
Apr 23, 2026
Contributor
|
Lead time: 2 hours, 47 minutes, 50 seconds (2.80 total hours) from first commit to close.
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
OrderableList's drag choreography (items shifting to make space) works in Storybook but does nothing once consumed from the published package.Why
Our Vite config used the array form of Rollup's
external, which only does exact-string matching. So@dnd-kit/reactwas external, but@dnd-kit/react/sortable(a subpath we actually use) wasn't. Rollup walked into it and bundled the transitive deps. Consumers ended up with two copies of dnd-kit's classes; theinstanceofchecks dnd-kit's registry uses internally silently failed and choreography never ran.Storybook didn't see this because it builds from source single class identity, no duplication.
This is a known Rollup/Vite footgun:
vite-plugin-externalize-depsfor this class of problemFix
Swap the array for a function that matches declared deps and their subpaths. One file, one option, no
package.jsonchanges.Verified
Rebuilt the dist (no more inlined dnd-kit classes), yalc-linked into web-app, drag-and-drop works.