fix: wrong asset type annotations #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivereisenhut
force-pushed
the
fix/asset-typing
branch
from
d1d9fbc to
c803cb3
Compare
imoutaharik
approved these changes
Jun 11, 2025
olivereisenhut
force-pushed
the
fix/asset-typing
branch
from
c803cb3 to
4efa5f5
Compare
olivereisenhut
force-pushed
the
fix/asset-typing
branch
from
a837f92 to
3964e57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the annotations were not quite true. Some fields are nullable in
GQL and some fields are not on the asset interface or both.
Those that are not on the interface can be
undefinedas they are not returned.For example, GQL doesn't return the field
bitratefor a fragment of the typeImage.