Expand visual context screenshot crop#104
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expands the screenshot crop used for visual prompt context so OCR sees more surrounding content above and beside the focused text field.
The crop now adds 100 display points of horizontal padding on both sides and doubles the vertical context above the input from 300 to 600 display points, while still clamping to the captured window bounds.
Validation
xcodebuild -project tabby.xcodeproj -scheme tabby -destination 'platform=macOS' build** BUILD SUCCEEDED **Linked issues
None.
Risk / rollout notes
This increases the amount of screenshot area sent through OCR. That can improve context quality, but may increase OCR latency and include more on-screen text in the bounded visual-context excerpt.