Align and enlarge activation indicator

[FuJacob]

Summary

Makes the field-edge Tabby activation indicator larger, visually flush with the focused input edge, and slightly lighter so the black app icon reads less heavy against text fields.

This keeps the change inside ActivationIndicatorController: the positioning gap is now zero for field-edge mode, the icon renders at 20pt instead of 16pt, and a small SwiftUI brightness adjustment softens the black without adding a new asset pipeline.

Validation

• git diff --check -> exit 0
• xcodebuild -project tabby.xcodeproj -scheme tabby -destination 'platform=macOS' build -> BUILD SUCCEEDED

Linked issues

None.

Risk / rollout notes

The indicator now touches the input frame edge exactly in field-edge mode. If a host app reports a slightly oversized AX input frame, the icon will align to that reported frame because Tabby intentionally treats Accessibility geometry as the source of truth.

Greptile Summary

This PR polishes the fieldEdgeIcon activation indicator: the positioning gap is reduced from 6 pt to 0 so the icon sits flush with the focused input's edge, the icon grows from 16 pt to 20 pt, a brightness(0.16) modifier lightens the black app icon, and the corner radius / shadow are nudged to match.

• horizontalGap (6) is replaced by fieldEdgeGap (0), affecting both the preferred-left and fallback-right computations in fieldEdgeIconOrigin, making the indicator flush on both sides.
• FieldEdgeIconIndicatorView gains .brightness(0.16) between .frame() and .clipShape(), which uniformly raises every color channel — safe for the current dark icon but worth keeping in mind if the icon gains colorful regions in the future.

Confidence Score: 4/5

Safe to merge — all changes are confined to visual presentation with no impact on logic, state, or Accessibility geometry handling.

The diff touches only layout constants and SwiftUI view modifiers inside a single private view. There are no data-flow changes, no new async paths, and the positioning arithmetic is identical apart from substituting 0 for the old 6-pt gap. The two observations are style-level: the right-side fallback silently inherits the zero gap without documentation, and the .brightness modifier sits after .frame() rather than closer to the image declaration — neither affects runtime correctness.

No files require special attention beyond a quick visual sanity-check of the right-side fallback rendering in ActivationIndicatorController.swift.

Important Files Changed

Filename	Overview
tabby/Services/UI/ActivationIndicatorController.swift	Visual-only polish: renames horizontalGap→fieldEdgeGap (value 0), grows icon from 16→20pt, adds brightness(0.16) lightening, and adjusts corner-radius/shadow. No logic changes outside positioning arithmetic.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["show(mode:caretRect:inputFrameRect:)"] --> B{mode?}
    B -- hidden --> C[hide]
    B -- caretAnchor --> D[caretAnchorOrigin]
    B -- fieldEdgeIcon --> E[fieldEdgeIconOrigin]

    E --> F{"inputFrameRect\navailable & non-empty?"}
    F -- yes --> G[anchorRect = inputFrameRect]
    F -- no --> H[anchorRect = caretRect]

    G & H --> I["preferredLeftX =\nanchorRect.minX − contentSize.width\n− fieldEdgeGap (0)"]
    I --> J["fallbackRightX =\nanchorRect.maxX\n+ fieldEdgeGap (0)"]
    J --> K{preferredLeftX ≥\nvisibleFrame.minX + screenInset?}
    K -- yes --> L[use preferredLeftX]
    K -- no --> M[use fallbackRightX]
    L & M --> N[clamp X & Y to screen bounds]
    N --> O[set panel frame & order front]

    D --> P[center on caret X, prefer below line]
    P --> N

Loading

Comments Outside Diff (1)

1. tabby/Services/UI/ActivationIndicatorController.swift, line 216-222 (link)

   .brightness(0.16) adds 0.16 to every color channel before clipping. Placing it before .clipShape() means the brightened pixels outside the rounded rectangle are computed but then discarded by the clip, which is harmless. However, inserting it between .frame() and .clipShape() rather than right after Image(nsImage:) is slightly non-idiomatic — typically image-level color adjustments come before layout modifiers so the intent (modify the image, not the layout box) is clear at a glance.

   Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

   

_{Reviews (1): Last reviewed commit: "Align activation indicator with field ed..." | Re-trigger Greptile}

Greptile also left 1 inline comment on this PR.

[greptile-apps]

With fieldEdgeGap = 0, the fallback-right path now also places the icon flush against the field's right edge. The intent for the preferred-left case (flush with the left edge) is clearly documented, but the symmetry on the right side is not. If a right-side fallback with zero gap ever looks visually abrupt — e.g. the icon immediately abutting text that overflows the field boundary — a dedicated fieldEdgeFallbackGap constant would make the asymmetric intent explicit and easy to adjust.

Suggested change

	/// Field-edge mode should visually touch the input's outside edge. A gap reads as accidental
	/// padding because the icon is an affordance for the field itself, not for the surrounding UI.
	private let fieldEdgeGap: CGFloat = 0
	/// Field-edge mode should visually touch the input's outside edge. A gap reads as accidental
	/// padding because the icon is an affordance for the field itself, not for the surrounding UI.
	private let fieldEdgeGap: CGFloat = 0
	/// When the indicator must fall back to the right side of the field (left-edge-hugging inputs),
	/// a small gap avoids abutting text that overflows the field boundary. Set to 0 to match the
	/// flush-edge intent, or raise to a small value (e.g. 4) if right-side fallback looks crowded.
	private let fieldEdgeFallbackGap: CGFloat = 0

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!