Update DMG layout for vertical background#114
Merged
Conversation
d466bae to
f98d01f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the release DMG to use the new vertical background asset at
assets/release/dmg_background.png.The source PNG is
1080x1520. The DMG script now treats it as 2x art and opens Finder at540x760, which keeps the vertical installer compact enough to avoid the oversized scrolling feel. The app icon is centered above the arrows and theApplicationsshortcut is centered in the dashed drop target.Validation
python3 -m py_compile scripts/build_release_dmg.py-> exit 0sips --resampleHeightWidth 760 540 assets/release/dmg_background.png --out /tmp/tabby-normalized-dmg-background-small.png-> output PNG is540x760python3 scripts/build_release_dmg.py --app-path /Users/jacobfu/Library/Developer/Xcode/DerivedData/tabby-fudilwczjhlrywbzrvmcjwzngjmh/Build/Products/Debug/tabby.app --output-path /tmp/Tabby-vertical-layout-test-small.dmg --background-path assets/release/dmg_background.png --volume-name TabbyTestSmall-> built styled DMG successfullyhdiutil imageinfo /tmp/Tabby-vertical-layout-test-small.dmg-> confirmed UDZO compressed DMGgit diff --check-> exit 0Linked issues
None.
Risk / rollout notes
This renames the release background path from
assets/release/dmg-background.pngtoassets/release/dmg_background.png; the release workflow and release docs were updated to match. The Finder window remains vertical, but is now much smaller than the first PR version.Greptile Summary
This PR replaces the horizontal DMG installer background with a new vertical
1080×1520asset, updating the Finder window dimensions and icon positions throughout the build script, workflow, and documentation.scripts/build_release_dmg.py: Window size changed from960×640to540×760(2× source-art convention), and both icon positions recentered for the vertical layout — app icon at(270, 280)and Applications shortcut at(270, 635)..github/workflows/release.yml/RELEASING.md: Background asset path renamed fromdmg-background.png(hyphen) todmg_background.png(underscore) and verification prose updated to describe the new above/below flow instead of left/right.assets/release/: Old horizontal PNG deleted, new vertical PNG added.Confidence Score: 5/5
Safe to merge — all changed files are DMG packaging infrastructure with no runtime app logic, and the asset rename is consistently applied across the workflow, script, and docs.
The layout constants in the script are internally self-consistent (2× source art at 1080×1520 maps cleanly to a 540×760 Finder window), the old asset reference has been fully replaced with the new underscore filename everywhere it appeared, and the author validated the full build end-to-end before opening the PR.
No files require special attention.
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A["release.yml\n--background-path assets/release/dmg_background.png"] --> B["build_release_dmg.py"] B --> C["require_existing_path(background_path)"] C --> D["normalize_background_image()\nsips --resampleHeightWidth 760 540\n1080×1520 → 540×760"] D --> E["write_settings_file()\nwindow_rect = 540×760\nAPP_ICON @ (270, 280)\nAPPS_ICON @ (270, 635)"] E --> F["dmgbuild → Tabby.dmg\nVertical installer layout"] F --> G["codesign --verify\nspctl --assess"]Reviews (2): Last reviewed commit: "Shrink vertical DMG window" | Re-trigger Greptile