Skip to content

Polish settings UI and disable user tags#115

Merged
FuJacob merged 1 commit into
mainfrom
ui/settings-cleanup
May 21, 2026
Merged

Polish settings UI and disable user tags#115
FuJacob merged 1 commit into
mainfrom
ui/settings-cleanup

Conversation

@FuJacob

@FuJacob FuJacob commented May 21, 2026

Copy link
Copy Markdown
Owner

Summary

  • Move Updates section to top of settings (most immediately useful)
  • Rename toggle from "Clipboard Context" → "Include Clipboard Context"
  • Comment out "Things you type often" (user tags) everywhere: settings profile section, onboarding step, and both prompt renderers (Llama + Foundation Model). The plumbing and storage remain intact for easy re-enablement.

Context

Tabby is still rough around the edges — no point shipping a feature we haven't validated yet. User tags add prompt tokens for unclear value. Disabling them now keeps the surface area small while we focus on core autocomplete quality.

Test plan

  • Build succeeds
  • Test build succeeds
  • Settings window shows Updates at the top
  • Toggle reads "Include Clipboard Context"
  • Profile section in settings only shows Name (no tags)
  • Onboarding profile step only shows Name (no tags)
  • Generated prompts do not include user tags even if previously saved

🤖 Generated with Claude Code

Greptile Summary

This PR polishes the settings UI and intentionally disables the user-tags feature across all surfaces while preserving the underlying storage for easy re-enablement later.

  • The Updates section is moved above General in SettingsView, the clipboard toggle is renamed to "Include Clipboard Context", and the "Things you type often" block is commented out (with a TODO) in both the settings profile section and the onboarding step.
  • Both prompt renderers (LlamaPromptRenderer and FoundationModelPromptRenderer) have their userTags injection commented out in parallel, so previously saved tags are never sent to a model even if they exist in storage.

Confidence Score: 4/5

Safe to merge — all user-tag surfaces are consistently disabled and the underlying storage is untouched.

The changes are narrow and consistent: both prompt renderers and both UI surfaces disable tags in lockstep, and the toggle rename and section reorder are straightforward. The only thing worth a second look is the stale doc comment in WelcomeProfileStepView that still describes collecting "common tags".

WelcomeProfileStepView.swift — its file-level doc comment still references tags collection.

Important Files Changed

Filename Overview
tabby/Support/FoundationModelPromptRenderer.swift User tags block commented out with TODO; no logic changes to the active prompt path
tabby/Support/LlamaPromptRenderer.swift Mirror of FoundationModelPromptRenderer change — user tags block commented out with matching TODO
tabby/UI/SettingsView.swift Updates section moved to top, toggle renamed to "Include Clipboard Context", profile tags commented out with TODO
tabby/UI/WelcomeProfileStepView.swift Tags section commented out; file-level doc comment still references collecting "common tags" which is now disabled

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[SuggestionSettingsModel\nuserTags stored ✓] -->|was read by| B[LlamaPromptRenderer\nuserTags block]
    A -->|was read by| C[FoundationModelPromptRenderer\nuserTags block]
    A -->|was shown in| D[SettingsView\nprofileSection]
    A -->|was shown in| E[WelcomeProfileStepView\nTags UI]
    B -->|now commented out 🚫| F[Llama Prompt\nno tags injected]
    C -->|now commented out 🚫| G[Foundation Model Prompt\nno tags injected]
    D -->|now commented out 🚫| H[Settings UI\nname only]
    E -->|now commented out 🚫| I[Onboarding UI\nname only]
Loading

Comments Outside Diff (1)

  1. tabby/UI/WelcomeProfileStepView.swift, line 3-4 (link)

    P2 The file-level doc comment still says "to collect the user's name and common tags," but the tags UI is now commented out. Per the AGENTS.md teaching comment standard, doc comments should accurately describe purpose and design — a stale description here will mislead anyone who reads it before re-enabling the feature.

    Context Used: AGENTS.md (source)

    Fix in Codex Fix in Claude Code

Fix All in Codex Fix All in Claude Code

Reviews (1): Last reviewed commit: "Polish settings UI and disable user tags..." | Re-trigger Greptile

Context used:

  • Context used - AGENTS.md (source)

- Move Updates section to the top of settings (most actionable for users)
- Rename "Clipboard Context" toggle to "Include Clipboard Context"
- Comment out "Things you type often" (user tags) in settings, onboarding,
  and both prompt renderers until we validate the feature's value

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@FuJacob FuJacob merged commit c8923f6 into main May 21, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant