Polish settings UI and disable user tags#115
Merged
Merged
Conversation
- Move Updates section to the top of settings (most actionable for users) - Rename "Clipboard Context" toggle to "Include Clipboard Context" - Comment out "Things you type often" (user tags) in settings, onboarding, and both prompt renderers until we validate the feature's value Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
Tabby is still rough around the edges — no point shipping a feature we haven't validated yet. User tags add prompt tokens for unclear value. Disabling them now keeps the surface area small while we focus on core autocomplete quality.
Test plan
🤖 Generated with Claude Code
Greptile Summary
This PR polishes the settings UI and intentionally disables the user-tags feature across all surfaces while preserving the underlying storage for easy re-enablement later.
SettingsView, the clipboard toggle is renamed to "Include Clipboard Context", and the "Things you type often" block is commented out (with a TODO) in both the settings profile section and the onboarding step.LlamaPromptRendererandFoundationModelPromptRenderer) have theiruserTagsinjection commented out in parallel, so previously saved tags are never sent to a model even if they exist in storage.Confidence Score: 4/5
Safe to merge — all user-tag surfaces are consistently disabled and the underlying storage is untouched.
The changes are narrow and consistent: both prompt renderers and both UI surfaces disable tags in lockstep, and the toggle rename and section reorder are straightforward. The only thing worth a second look is the stale doc comment in WelcomeProfileStepView that still describes collecting "common tags".
WelcomeProfileStepView.swift — its file-level doc comment still references tags collection.
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[SuggestionSettingsModel\nuserTags stored ✓] -->|was read by| B[LlamaPromptRenderer\nuserTags block] A -->|was read by| C[FoundationModelPromptRenderer\nuserTags block] A -->|was shown in| D[SettingsView\nprofileSection] A -->|was shown in| E[WelcomeProfileStepView\nTags UI] B -->|now commented out 🚫| F[Llama Prompt\nno tags injected] C -->|now commented out 🚫| G[Foundation Model Prompt\nno tags injected] D -->|now commented out 🚫| H[Settings UI\nname only] E -->|now commented out 🚫| I[Onboarding UI\nname only]Comments Outside Diff (1)
tabby/UI/WelcomeProfileStepView.swift, line 3-4 (link)Context Used: AGENTS.md (source)
Reviews (1): Last reviewed commit: "Polish settings UI and disable user tags..." | Re-trigger Greptile
Context used: