Skip to content

Update Package.resolved for remote CotabbyInference dependency#221

Merged
FuJacob merged 1 commit into
mainfrom
fix/post-merge-cleanup
May 25, 2026
Merged

Update Package.resolved for remote CotabbyInference dependency#221
FuJacob merged 1 commit into
mainfrom
fix/post-merge-cleanup

Conversation

@FuJacob
Copy link
Copy Markdown
Owner

@FuJacob FuJacob commented May 25, 2026

Summary

The Package.resolved update was pushed to rename/cotabby after #202 was merged, so it didn't make it into main. This adds the resolved entry for the remote cotabbyinference git dependency.

Validation

xcodebuild -project Cotabby.xcodeproj -scheme Cotabby -destination 'platform=macOS' build
# ** BUILD SUCCEEDED **

xcodebuild -project Cotabby.xcodeproj -scheme Cotabby -destination 'platform=macOS' build-for-testing
# ** TEST BUILD SUCCEEDED **

Linked issues

Follow-up to #202.

Risk / rollout notes

Lock file only — no code changes.

Greptile Summary

This PR adds the missing Package.resolved pin for the remote cotabbyinference SwiftPM dependency that was omitted when #202 was merged into main; no source code is changed.

  • Adds a new cotabbyinference entry pinned to commit 662df9f on the main branch of https://github.com/FuJacob/cotabbyinference.git, and updates the file's originHash accordingly.
  • The two existing pins (sparkle 2.9.1, swift-log 1.12.1) remain unchanged; cotabbyinference is the only dependency without a version tag, meaning a future package-resolve step could silently advance the pin.

Confidence Score: 4/5

Safe to merge — lock file only, no source changes, build validation passed.

The change is a single lock file update that restores a missing dependency pin. The revision is captured, so current builds are reproducible. The only concern is that the pin tracks a branch rather than a version tag, which means a future Xcode 'Resolve Package Versions' step could silently move to a newer commit without an explicit version bump in the manifest.

No files require special attention beyond the branch-only pin in Package.resolved.

Important Files Changed

Filename Overview
Cotabby.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved Adds the missing cotabbyinference pin (branch: main, revision: 662df9f) and updates the originHash; pin uses a branch instead of a version tag, unlike the other two dependencies in the file.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Package.resolved] --> B[cotabbyinference\nbranch: main\nrevision: 662df9f]
    A --> C[sparkle\nversion: 2.9.1\nrevision: 066e75a]
    A --> D[swift-log\nversion: 1.12.1\nrevision: a012e0a]

    B -->|branch pin| E["⚠️ Future resolve may\nadvance to new commit"]
    C -->|version tag| F["✅ Stable semantic anchor"]
    D -->|version tag| F
Loading

Fix All in Codex Fix All in Claude Code

Reviews (1): Last reviewed commit: "Update Package.resolved for remote Cotab..." | Re-trigger Greptile

Greptile also left 1 inline comment on this PR.

@FuJacob FuJacob merged commit 313b941 into main May 25, 2026
3 checks passed
Comment on lines +8 to +11
"state" : {
"branch" : "main",
"revision" : "662df9f1b71b900231629171572181806bd2fa36"
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Branch-based pin instead of version tag

The cotabbyinference entry uses "branch": "main" rather than a version tag. The other two dependencies (sparkle and swift-log) carry a "version" field alongside their revision, giving SPM a stable semantic anchor. With a branch-only pin, any swift package update or Xcode "Resolve Package Versions" step will silently advance to whatever commit is at the tip of main at that moment, potentially pulling in breaking changes without an explicit version bump in the manifest. Consider publishing a version tag on cotabbyinference and referencing it here so the lock file entry gains the same reproducibility as the other pins.

Fix in Codex Fix in Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant