Update Package.resolved for remote CotabbyInference dependency#221
Merged
Conversation
Comment on lines
+8
to
+11
| "state" : { | ||
| "branch" : "main", | ||
| "revision" : "662df9f1b71b900231629171572181806bd2fa36" | ||
| } |
Contributor
There was a problem hiding this comment.
Branch-based pin instead of version tag
The cotabbyinference entry uses "branch": "main" rather than a version tag. The other two dependencies (sparkle and swift-log) carry a "version" field alongside their revision, giving SPM a stable semantic anchor. With a branch-only pin, any swift package update or Xcode "Resolve Package Versions" step will silently advance to whatever commit is at the tip of main at that moment, potentially pulling in breaking changes without an explicit version bump in the manifest. Consider publishing a version tag on cotabbyinference and referencing it here so the lock file entry gains the same reproducibility as the other pins.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Package.resolved update was pushed to
rename/cotabbyafter #202 was merged, so it didn't make it into main. This adds the resolved entry for the remotecotabbyinferencegit dependency.Validation
Linked issues
Follow-up to #202.
Risk / rollout notes
Lock file only — no code changes.
Greptile Summary
This PR adds the missing
Package.resolvedpin for the remotecotabbyinferenceSwiftPM dependency that was omitted when #202 was merged intomain; no source code is changed.cotabbyinferenceentry pinned to commit662df9fon themainbranch ofhttps://github.com/FuJacob/cotabbyinference.git, and updates the file'soriginHashaccordingly.sparkle 2.9.1,swift-log 1.12.1) remain unchanged;cotabbyinferenceis the only dependency without a version tag, meaning a future package-resolve step could silently advance the pin.Confidence Score: 4/5
Safe to merge — lock file only, no source changes, build validation passed.
The change is a single lock file update that restores a missing dependency pin. The revision is captured, so current builds are reproducible. The only concern is that the pin tracks a branch rather than a version tag, which means a future Xcode 'Resolve Package Versions' step could silently move to a newer commit without an explicit version bump in the manifest.
No files require special attention beyond the branch-only pin in Package.resolved.
Important Files Changed
cotabbyinferencepin (branch: main, revision: 662df9f) and updates the originHash; pin uses a branch instead of a version tag, unlike the other two dependencies in the file.Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[Package.resolved] --> B[cotabbyinference\nbranch: main\nrevision: 662df9f] A --> C[sparkle\nversion: 2.9.1\nrevision: 066e75a] A --> D[swift-log\nversion: 1.12.1\nrevision: a012e0a] B -->|branch pin| E["⚠️ Future resolve may\nadvance to new commit"] C -->|version tag| F["✅ Stable semantic anchor"] D -->|version tag| FReviews (1): Last reviewed commit: "Update Package.resolved for remote Cotab..." | Re-trigger Greptile