Replace paw symbol with Cotabby cat logo across UI#237
Merged
Conversation
Swap the SF Symbol pawprint for the new cat branding everywhere it shows: - MenuBarCatIcon: black-on-transparent template silhouette (cat peeking past the cursor bar) for the menu-bar label and the field-edge activation indicator, so macOS recolors it for light/dark bars. - CotabbyLogo: full-color app icon used in the Settings header and Welcome screen, clipped to rounded corners. - Remove the now-unused WelcomeAppIcon (old paw) asset.
Comment on lines
+15
to
+19
| Image("MenuBarCatIcon") | ||
| .renderingMode(.template) | ||
| .resizable() | ||
| .scaledToFit() | ||
| .frame(height: 16) |
Contributor
There was a problem hiding this comment.
Accessibility regression from custom asset image.
Image(systemName: "pawprint.fill") automatically exposed a VoiceOver label derived from the symbol name. A custom Image("MenuBarCatIcon") has no implicit accessibility description, so VoiceOver will announce it as a generic "image" (or skip it). Since the icon is decorative next to the text label, marking it hidden from accessibility is the cleaner fix.
Suggested change
| Image("MenuBarCatIcon") | |
| .renderingMode(.template) | |
| .resizable() | |
| .scaledToFit() | |
| .frame(height: 16) | |
| Image("MenuBarCatIcon") | |
| .renderingMode(.template) | |
| .resizable() | |
| .scaledToFit() | |
| .frame(height: 16) | |
| .accessibilityHidden(true) |
The DMG and Finder/dock icon still showed the old paw AppIcon. Swap all mac AppIcon sizes (16-1024) for the new cat-and-cursor artwork. Contents.json is unchanged (same size/scale layout).
Regenerate all icon assets from the new dark-navy cat render: AppIcon (16-1024), CotabbyLogo (Settings/Welcome), and the MenuBarCatIcon silhouette (menu bar + activation indicator).
- AppIcon (16-1024) and CotabbyLogo (Settings/Welcome) use the new blue cat artwork. - Menu-bar/indicator keep the existing clean MenuBarCatIcon silhouette; the new render is too furry to threshold into a crisp template glyph. - Activation indicator now uses a fixed gray badge with a white logo, instead of the adaptive light/dark treatment. - Remove unused README demo images (slack/notes/imessage are remote-hosted).
Swap the rounded color logo for the bare MenuBarCatIcon silhouette (white, no container) so onboarding matches the menu-bar/indicator glyph.
Revert the bare silhouette back to the rounded CotabbyLogo app-icon mark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the placeholder paw branding with the new Cotabby cat across the entire UI and the app icon:
MenuBarCatIcontemplate so macOS recolors it for light/dark bars.CotabbyLogowith rounded corners.WelcomeAppIcon(old paw) asset.Validation
Verified the
MenuBarCatIcontemplate renders cleanly (black on light bars, white on dark bars). The DMG background art (assets/release/dmg_background.png) is generic (no logo) and unchanged.Linked issues
Risk / rollout notes
MenuBarCatIcon,CotabbyLogo) and the AppIcon PNGs live inside the existingAssets.xcassets; AppIconContents.jsonis unchanged, so noproject.pbxprojchange was needed.logo-white.pngfrom the asset drop had no alpha channel (white-on-white), so the menu-bar silhouette was derived from the higher-fidelityappstore.png(same artwork).Greptile Summary
This PR is a purely cosmetic rebrand that swaps the placeholder paw symbol for the new Cotabby cat artwork across every UI surface — app icon, menu bar, activation indicator, settings header, and welcome screen — with no behavioral or data-model changes.
MenuBarCatIcon,CotabbyLogo) replace all paw assets;MenuBarCatIconis correctly declared as a template image so macOS applies system tinting in the menu bar.MenuBarStatusLabelView,SettingsView, andWelcomeVieware straightforward SF-Symbol-to-asset-image swaps with properrenderingMode, sizing, and clipping.ActivationIndicatorControllerremoves the@Environment(\\.colorScheme)adaptive background and hard-codes a dark slate color, which may look out of place in light mode — the only minor concern in an otherwise clean change.Confidence Score: 5/5
Safe to merge — all changes are cosmetic asset replacements with no logic, schema, or behavioral impact.
Every Swift change is a direct symbol-to-asset swap with no altered control flow. The only nuance is the activation indicator's hardcoded dark background, which is a visual trade-off rather than a defect. No data, settings, or runtime paths are touched.
No files require special attention; ActivationIndicatorController.swift has a minor cosmetic trade-off worth a second glance in light mode.
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[Assets.xcassets] --> B[AppIcon.appiconset\n16–1024 px PNGs] A --> C[MenuBarCatIcon.imageset\ntemplate rendering] A --> D[CotabbyLogo.imageset\nfull-color · 1x/2x/3x] A --> E[WelcomeAppIcon.imageset\n removed] C --> F[MenuBarStatusLabelView\nmenu bar label icon] C --> G[ActivationIndicatorController\nfield-edge indicator] D --> H[SettingsView\nheader logo] D --> I[WelcomeView\nonboarding logo]Reviews (6): Last reviewed commit: "Use charcoal background for the activati..." | Re-trigger Greptile