Skip to content

Reorder menu bar toggles and clarify their labels#240

Merged
FuJacob merged 1 commit into
mainfrom
menu-bar-toggle-reorder
May 25, 2026
Merged

Reorder menu bar toggles and clarify their labels#240
FuJacob merged 1 commit into
mainfrom
menu-bar-toggle-reorder

Conversation

@FuJacob
Copy link
Copy Markdown
Owner

@FuJacob FuJacob commented May 25, 2026

Summary

Tightens the menu bar quick-controls layout. The per-app enable/disable toggle now sits directly beneath Enable Globally so the two scope controls are adjacent. Show Indicator is renamed to Show Cotabby Indicator, and the multi-line switch is relabeled Allow Multi-line Suggestions and moved up next to the other behavior toggles instead of trailing the engine/model/length pickers.

Note: the per-app toggle (Enable in <app>) is conditional on a focused non-terminal external app, so it only renders when Cotabby has tracked one — it was never removed, just positioned below the clipboard toggle.

Validation

xcodebuild -project Cotabby.xcodeproj -scheme Cotabby -destination 'platform=macOS' build
# ** BUILD SUCCEEDED **

swiftlint lint --quiet Cotabby/UI/MenuBarView.swift
# exit 0

UI-only change to existing toggles; behavior of each setting is unchanged.

Linked issues

None.

Risk / rollout notes

Pure presentation change — toggle order and labels only. No settings, schema, or persistence changes.

Greptile Summary

This PR reorders the toggle controls in the menu bar panel and clarifies two toggle labels. No bindings, settings persistence, or behavioral logic is changed.

  • Moves "Enable in <app>" directly below "Enable Globally" so the two scope controls are adjacent, then groups clipboard, indicator, and multi-line toggles together before the engine/model/length pickers.
  • Renames "Show Indicator" → "Show Cotabby Indicator" and "Multi-line" → "Allow Multi-line Suggestions" for clarity.

Confidence Score: 5/5

Safe to merge — purely reorders existing toggles and updates two labels with no functional changes.

Every toggle retains its original binding and behavior. The two renamed labels are purely cosmetic strings. The new ordering groups scope controls together and places all toggles before the pickers, which is a sensible UX improvement with no risk of breakage.

No files require special attention.

Important Files Changed

Filename Overview
Cotabby/UI/MenuBarView.swift Toggle reorder and two label renames; all bindings and logic are unchanged.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Enable Globally] --> B{latestExternalApplication\nnon-terminal?}
    B -- yes --> C[Enable in app]
    B -- no --> D[Include Clipboard Context]
    C --> D
    D --> E[Show Cotabby Indicator]
    E --> F[Allow Multi-line Suggestions]
    F --> G[Engine picker]
    G --> H{selectedEngine ==\nappleIntelligence\n&& unavailable?}
    H -- yes --> I[Availability warning]
    H -- no --> J{supportsLocal\nModelManagement?}
    I --> J
    J -- yes --> K[Model picker]
    J -- no --> L[Length picker]
    K --> L
Loading

Reviews (1): Last reviewed commit: "Reorder menu bar toggles and clarify the..." | Re-trigger Greptile

Move the per-app enable/disable toggle directly under "Enable Globally"
so both scope controls sit together. Rename "Show Indicator" to "Show
Cotabby Indicator" and relabel the multi-line toggle to "Allow Multi-line
Suggestions", moving it up beneath the indicator toggle next to the other
behavior switches instead of trailing the engine/model/length pickers.
@FuJacob FuJacob merged commit a3d9bd6 into main May 25, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant