Add two more downloadable models (four defaults)#245
Merged
Conversation
Activate the 'newer models' that were commented out on the inference-engine branch, giving four built-in downloadable GGUF models across fast/balanced/ quality tiers: - Cotabby-fast-1 Qwen3-0.6B (~0.4 GB, existing) - Cotabby-fast-2 Qwen3.5-0.8B (~0.5 GB, new) - Cotabby-balanced-1 gemma-3-1b (~0.8 GB, existing) - Cotabby-quality-1 gemma-4-E2B (~3.1 GB, new) Display names route through displayName(for:) for consistency; expected size and SHA-256 carried over from the captured HuggingFace CDN headers (both URLs verified live, HTTP 200). README model table updated to match.
Display names: cotabby-swift-1, cotabby-swift-pro-1, cotabby-balanced-1, cotabby-careful-1. All four download URLs verified end to end (GGUF magic, served size matches expectedSizeBytes, and x-linked-etag matches the committed SHA-256), so downloads initiate and pass the install-time validator.
Owner
Author
|
Confirmed the
Same end-to-end check passed for all four models (magic + size + SHA-256), so the download/validation gate will accept them. The 'Qwen3.5' naming is Unsloth's repo name for this quant; the metadata is captured from that exact file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Activates the two "newer models" that were sitting commented-out on the inference-engine branch, so the built-in downloadable catalog now offers four GGUF models across fast/balanced/quality tiers:
Cotabby-fast-1Qwen3-0.6B-Q4_K_M.ggufCotabby-fast-2Qwen3.5-0.8B-Q4_K_M.ggufCotabby-balanced-1gemma-3-1b-it-Q4_K_M.ggufCotabby-quality-1gemma-4-E2B-it-Q4_K_M.ggufDisplay names route through
displayName(for:)for consistency;expectedSizeBytes/sha256carried over from the captured HuggingFace CDN headers.Validation
Both new download URLs verified live (HTTP 200) via
curl -sIL. No test asserts the catalog count, so none needed updating. README model table updated to match.Linked issues
Risk / rollout notes
Cotabby-quality-1is ~3.1 GB; it's opt-in to download like the others.LlamaRuntimeConfiguration.preferredModelNames(runtime auto-load priority) left as-is; the new models are downloadable but not forced as the auto-load default.Greptile Summary
This PR expands the built-in downloadable model catalog from two entries to four by activating two previously commented-out models (
Qwen3.5-0.8B-Q4_K_M.ggufandgemma-4-E2B-it-Q4_K_M.gguf), and renames all display names to a consistent lowercasecotabby-*scheme.DownloadableRuntimeModelstructs includeexpectedSizeBytesandsha256fields populated from HuggingFace CDN headers, which the existing size + SHA-256 validation gate will enforce on download.cotabby-swift-1,cotabby-balanced-1); since model identity usesfilenameasid, not the display string, existing user selections are unaffected.LlamaRuntimeConfiguration.preferredModelNamesis intentionally left with only the original two entries — the new models are opt-in downloads, not auto-load defaults.Confidence Score: 5/5
Additive catalog change only — no existing behavior altered, download validation gate unchanged, and model identity relies on filenames not display strings.
The two new catalog entries follow the exact same pattern as the two existing ones, with expectedSizeBytes and sha256 populated so the validation gate will reject corrupt or wrong downloads. The display name rename from title-case to lowercase is cosmetic and safe because id is always the raw filename. Tests are updated to match, and preferredModelNames is left intentionally narrow.
No files require special attention.
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[RuntimeModelCatalog.downloadableModels] --> B[Qwen3-0.6B-Q4_K_M.gguf\ncotabby-swift-1 ~0.4 GB] A --> C[Qwen3.5-0.8B-Q4_K_M.gguf\ncotabby-swift-pro-1 ~0.5 GB\nNEW] A --> D[gemma-3-1b-it-Q4_K_M.gguf\ncotabby-balanced-1 ~0.8 GB] A --> E[gemma-4-E2B-it-Q4_K_M.gguf\ncotabby-careful-1 ~3.1 GB\nNEW] B & C & D & E --> F[displayName for filename] F --> G[DownloadableRuntimeModel\nfilename · displayName · downloadURL\nexpectedSizeBytes · sha256] G --> H[Download Manager] H --> I{Size + SHA-256 gate} I -->|pass| J[Install to models folder] I -->|fail| K[Reject staged file] L[LlamaRuntimeConfiguration.preferredModelNames] --> M[gemma-3-1b-it-Q4_K_M.gguf\nQwen3-0.6B-Q4_K_M.gguf] M --> N[Auto-load priority\nnew models excluded intentionally]Comments Outside Diff (1)
Cotabby/Models/LlamaRuntimeModels.swift, line 88-99 (link)The PR summary table uses
Cotabby-fast-1,Cotabby-fast-2,Cotabby-balanced-1, andCotabby-quality-1, but the code (and README) now usesCotabby-Swift-1,Cotabby-Swift+-1,Cotabby-Balanced-1, andCotabby-Careful-1. This is only a description inconsistency and won't affect runtime behaviour, but it may confuse reviewers or anyone searching for the names later.Reviews (2): Last reviewed commit: "Rename model tiers to lowercase; swift+ ..." | Re-trigger Greptile