Group Settings General into cards, surface Fast Mode + clarify context cost#370
Merged
Conversation
Comment on lines
+4
to
+8
| /// "General" detail pane of the redesigned Settings window. Groups settings into four visually | ||
| /// separated `Section`s (`.formStyle(.grouped)` renders each as its own rounded card, which is | ||
| /// the macOS-native equivalent of a divider): top-level on/off toggles, behavior tuning, display | ||
| /// surface, and appearance. The `Display` picker label here matches the same name used by the | ||
| /// menu-bar quick control so users can connect the two. |
Contributor
There was a problem hiding this comment.
Doc comment says "four" but five
Sections are present
The file-overview comment says the view groups settings into "four visually separated Sections", but the body contains five: the unlabeled top card, Behavior, Display, Appearance, and the unlabeled Onboarding card at the bottom. The count mismatch could mislead a future reader counting sections when adding or reordering them.
Suggested change
| /// "General" detail pane of the redesigned Settings window. Groups settings into four visually | |
| /// separated `Section`s (`.formStyle(.grouped)` renders each as its own rounded card, which is | |
| /// the macOS-native equivalent of a divider): top-level on/off toggles, behavior tuning, display | |
| /// surface, and appearance. The `Display` picker label here matches the same name used by the | |
| /// menu-bar quick control so users can connect the two. | |
| /// separated `Section`s (`.formStyle(.grouped)` renders each as its own rounded card, which is | |
| /// the macOS-native equivalent of a divider): top-level on/off toggles, behavior tuning, display | |
| /// surface, appearance, and onboarding. The `Display` picker label here matches the same name used by the |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits the General pane into four grouped Sections that render as separate cards under
.formStyle(.grouped)(the macOS-native equivalent of dividers), moves Fast Mode to the top alongside Enable Globally with a(no screen context)suffix so the cost is visible, and keeps the picker label as "Suggestion Display".Layout:
Build + lint clean.
Greptile Summary
This PR reorganises the General settings pane by splitting a single flat
Sectioninto five groupedSections that render as native rounded cards under.formStyle(.grouped). Fast Mode is promoted to the top card alongside "Enable Globally" and gains a(no screen context)suffix to make its cost visible.Confidence Score: 5/5
Safe to merge — purely a visual grouping change with no logic touched.
Every binding, model call, and behavioral path in the file is untouched. The only changes are how existing controls are wrapped in Section containers and the label text of the Fast Mode toggle. The sole noteworthy item is a doc comment that says four sections when there are five — harmless and easy to fix.
No files require special attention; the single changed file is a straightforward layout rearrangement.
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[GeneralPaneView] --> B[SettingsPaneScaffold] B --> C["Section (unlabeled)\nEnable Globally\nFast Mode (no screen context)"] B --> D["Section: Behavior\nInclude Clipboard Context\nAllow Multi-line Suggestions\nAccept Punctuation With Word"] B --> E["Section: Display\nSuggestion Display picker\nShow Indicator\nShow Key Hint toggle"] B --> F["Section: Appearance\nGhost Text Color swatches\nGhost Text Opacity slider"] B --> G["Section (unlabeled)\nOnboarding → Open Welcome Guide"]Reviews (1): Last reviewed commit: "Group Settings General into cards, surfa..." | Re-trigger Greptile