Rename built-in models to the tabby-1-* family#372
Merged
Conversation
Aligns the four downloadable presets under a single, version-prefixed naming scheme so we can iterate on them as a family: tabby-nano-2 → tabby-1-nano tabby-fast-1 → tabby-1-mini tabby-balanced-1 → tabby-1-base tabby-max-1 → tabby-1-pro Only the display labels change; the underlying GGUF filenames and download URLs are untouched, so installs and per-model settings keyed off filenames continue to resolve correctly.
Comment on lines
146
to
154
| XCTAssertEqual( | ||
| RuntimeModelCatalog.displayName(for: "Qwen3-0.6B-Q4_K_M.gguf"), | ||
| "tabby-fast-1" | ||
| "tabby-1-mini" | ||
| ) | ||
| XCTAssertEqual( | ||
| RuntimeModelCatalog.displayName(for: "gemma-4-E2B-it-Q4_K_M.gguf"), | ||
| "tabby-balanced-1" | ||
| "tabby-1-base" | ||
| ) | ||
| // Retired models fall back to their raw filename like any unknown local GGUF. |
Contributor
There was a problem hiding this comment.
The test function only asserts the new display names for
tabby-1-mini and tabby-1-base, leaving tabby-1-pro (gemma-4-E4B-it-Q4_K_M.gguf) and tabby-1-nano (SmolLM2-135M-Instruct-q8_0.gguf) uncovered. A typo in either of those two return strings would not be caught by this suite.
Suggested change
| XCTAssertEqual( | |
| RuntimeModelCatalog.displayName(for: "Qwen3-0.6B-Q4_K_M.gguf"), | |
| "tabby-fast-1" | |
| "tabby-1-mini" | |
| ) | |
| XCTAssertEqual( | |
| RuntimeModelCatalog.displayName(for: "gemma-4-E2B-it-Q4_K_M.gguf"), | |
| "tabby-balanced-1" | |
| "tabby-1-base" | |
| ) | |
| // Retired models fall back to their raw filename like any unknown local GGUF. | |
| XCTAssertEqual( | |
| RuntimeModelCatalog.displayName(for: "Qwen3-0.6B-Q4_K_M.gguf"), | |
| "tabby-1-mini" | |
| ) | |
| XCTAssertEqual( | |
| RuntimeModelCatalog.displayName(for: "gemma-4-E2B-it-Q4_K_M.gguf"), | |
| "tabby-1-base" | |
| ) | |
| XCTAssertEqual( | |
| RuntimeModelCatalog.displayName(for: "gemma-4-E4B-it-Q4_K_M.gguf"), | |
| "tabby-1-pro" | |
| ) | |
| XCTAssertEqual( | |
| RuntimeModelCatalog.displayName(for: "SmolLM2-135M-Instruct-q8_0.gguf"), | |
| "tabby-1-nano" | |
| ) | |
| // Retired models fall back to their raw filename like any unknown local GGUF. |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns the four built-in downloadable model presets under a single, version-prefixed naming scheme so future iterations land as a family rather than a one-off rename. Display labels only; the underlying GGUF filenames are untouched.
tabby-nano-2tabby-1-nanotabby-fast-1tabby-1-minitabby-balanced-1tabby-1-basetabby-max-1tabby-1-proValidation
Verified
grep -rnfor both old and new names: no stale references remain.Risk / rollout notes
RuntimeModelCatalog.displayName(for:)switch is keyed on the GGUF filename, which is unchanged, so already-downloaded models keep working and per-model settings keyed off filename keep resolving correctly.Cotabby/Models/LlamaRuntimeModels.swift(the catalog),CotabbyTests/ModelAndPresentationValueTests.swift(test expectations), andREADME.md(the user-facing table).Greptile Summary
This PR renames the four built-in downloadable model presets from ad-hoc names (
tabby-nano-2,tabby-fast-1,tabby-balanced-1,tabby-max-1) to a unifiedtabby-1-*family (tabby-1-nano,tabby-1-mini,tabby-1-base,tabby-1-pro). The change is purely presentational — GGUF filenames used as switch keys and settings identifiers are untouched.LlamaRuntimeModels.swift: All fourreturnstrings inRuntimeModelCatalog.displayName(for:)updated to the new naming scheme.ModelAndPresentationValueTests.swift: Test expectations refreshed for two of the four models;tabby-1-proandtabby-1-nanoassertions are absent.README.md: User-facing model table updated to show all four new names alongside their unchanged GGUF filenames and download sources.Confidence Score: 4/5
Safe to merge — the rename is purely presentational and the underlying GGUF filenames used as persistent identifiers are unchanged.
The catalog logic and README are correct and complete. The test suite only exercises two of the four renamed branches, so a future typo in the
tabby-1-proortabby-1-nanoreturn strings would go undetected until runtime.CotabbyTests/ModelAndPresentationValueTests.swift — missing assertions for
tabby-1-proandtabby-1-nano.Important Files Changed
RuntimeModelCatalog.displayName(for:)correctly renamed to thetabby-1-*family; GGUF filenames (the switch keys) are untouched.tabby-1-proandtabby-1-nanoassertions are missing, leaving those branches untested.tabby-1-*names; GGUF filenames, sizes, and HuggingFace source links are unchanged.Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[GGUF filename\nswitch key] --> B{RuntimeModelCatalog\n.displayName} B -->|Qwen3-0.6B-Q4_K_M.gguf| C["tabby-1-mini ✓"] B -->|gemma-4-E2B-it-Q4_K_M.gguf| D["tabby-1-base ✓"] B -->|gemma-4-E4B-it-Q4_K_M.gguf| E["tabby-1-pro ✓"] B -->|SmolLM2-135M-Instruct-q8_0.gguf| F["tabby-1-nano ✓"] B -->|anything else| G[raw filename] C -->|tested| H([✅ test coverage]) D -->|tested| H E -->|not tested| I([⚠️ no assertion]) F -->|not tested| IReviews (1): Last reviewed commit: "Rename built-in models to the tabby-1-* ..." | Re-trigger Greptile