Skip to content

Widen Settings sidebar and label the orphan About section#377

Merged
FuJacob merged 1 commit into
mainfrom
fix/settings-sidebar-width-and-about-section
May 28, 2026
Merged

Widen Settings sidebar and label the orphan About section#377
FuJacob merged 1 commit into
mainfrom
fix/settings-sidebar-width-and-about-section

Conversation

@FuJacob
Copy link
Copy Markdown
Owner

@FuJacob FuJacob commented May 28, 2026

Summary

Two visual issues in the Settings sidebar:

  1. "Apple Intelligence" truncated — the row is a sub-row with a 16pt leading indent, eating into the 220–240pt sidebar width. Bump column range to 260/280/320 and lift container minWidth from 780 → 820 so the detail pane keeps its working width.
  2. Awkward gap between Permissions and About — the meta section had title: nil but SwiftUI still applied inter-section spacing, reading as an unexplained gap. Give the section the title "Info" so the gap reads as a deliberate group boundary.

Validation

swiftlint lint --quiet                                  # exit 0
xcodebuild -project Cotabby.xcodeproj -scheme Cotabby \
  -destination 'platform=macOS' build                   # ** BUILD SUCCEEDED **

Diff is three files of pure layout-knob changes; no behavior touched.

Risk / rollout notes

  • Window's minWidth bumps from 780 → 820. Users with the window already sized larger are unaffected; the minimum just shifts up by 40pt.
  • No data migration needed.

Greptile Summary

Fixes two visual regressions in the Settings sidebar: "Apple Intelligence" was truncating because the sub-row's 16pt indent consumed usable label space within the old 220–240pt column range, and the meta section's missing header title produced an unexplained gap between Permissions and About.

  • Sidebar width (SettingsSidebarView.swift): column range widened to 260/280/320 so the longest sub-row label has real room at the minimum window size.
  • Container floor (SettingsContainerView.swift): minWidth bumped from 780 → 820 to keep the detail pane at a comfortable ~560pt alongside the wider sidebar.
  • Section header (SettingsCategory.swift): meta section given the title "Info" so SwiftUI renders an explicit group boundary instead of silent inter-section spacing.

Confidence Score: 4/5

Safe to merge — all three changed files contain only layout constant and string-literal changes with no behavioral side effects.

The window's minWidth nudges up by 40pt and a section header string changes from absent to Info; neither touches logic, data, or user state. The only finding is a stale (240) reference in a comment that should now read (280) to match the updated ideal column width.

The stale comment in SettingsContainerView.swift is the only line worth a second look.

Important Files Changed

Filename Overview
Cotabby/UI/Settings/SettingsCategory.swift Gives the meta section the title "Info" so the gap between Permissions and About reads as a deliberate section boundary rather than stray spacing.
Cotabby/UI/Settings/SettingsContainerView.swift Bumps minWidth from 780 → 820 to match the wider sidebar; contains one stale comment that still references the old ideal width of 240 instead of the new 280.
Cotabby/UI/Settings/SettingsSidebarView.swift Widens sidebar column range from 220/240/280 → 260/280/320 to prevent "Apple Intelligence" sub-row from truncating at minimum window size.

Comments Outside Diff (1)

  1. Cotabby/UI/Settings/SettingsContainerView.swift, line 54 (link)

    P2 This comment was written when the sidebar ideal was 240pt and was not updated alongside the column-width change. It now misrepresents the actual ideal width of 280pt, which is what the arithmetic in the next comment block uses.

    Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

    Fix in Codex Fix in Claude Code

Fix All in Codex Fix All in Claude Code

Reviews (1): Last reviewed commit: "Widen Settings sidebar and label the orp..." | Re-trigger Greptile

Two visual issues in the Settings sidebar after the recent redesign:

- "Apple Intelligence" still truncated to "Apple Intellig…" because
  that row is a sub-row with a 16pt leading indent, eating into the
  220–240pt sidebar width. Bump the column range to 260/280/320 so the
  longest sub-row label fits even when `.balanced` clamps to the floor,
  and raise the container `minWidth` from 780 → 820 so the detail pane
  keeps its working width alongside the wider sidebar.

- About sat below Permissions with no section header but inherited the
  grouped sidebar's inter-section spacing, reading as an unexplained
  gap. Give the trailing `meta` section the title "Info" so the gap
  reads as a deliberate group boundary instead of a layout glitch.
@FuJacob FuJacob merged commit 34bedfb into main May 28, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant