Widen Settings sidebar and label the orphan About section#377
Merged
Conversation
Two visual issues in the Settings sidebar after the recent redesign: - "Apple Intelligence" still truncated to "Apple Intellig…" because that row is a sub-row with a 16pt leading indent, eating into the 220–240pt sidebar width. Bump the column range to 260/280/320 so the longest sub-row label fits even when `.balanced` clamps to the floor, and raise the container `minWidth` from 780 → 820 so the detail pane keeps its working width alongside the wider sidebar. - About sat below Permissions with no section header but inherited the grouped sidebar's inter-section spacing, reading as an unexplained gap. Give the trailing `meta` section the title "Info" so the gap reads as a deliberate group boundary instead of a layout glitch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two visual issues in the Settings sidebar:
minWidthfrom 780 → 820 so the detail pane keeps its working width.metasection hadtitle: nilbut SwiftUI still applied inter-section spacing, reading as an unexplained gap. Give the section the title "Info" so the gap reads as a deliberate group boundary.Validation
Diff is three files of pure layout-knob changes; no behavior touched.
Risk / rollout notes
minWidthbumps from 780 → 820. Users with the window already sized larger are unaffected; the minimum just shifts up by 40pt.Greptile Summary
Fixes two visual regressions in the Settings sidebar: "Apple Intelligence" was truncating because the sub-row's 16pt indent consumed usable label space within the old 220–240pt column range, and the
metasection's missing header title produced an unexplained gap between Permissions and About.SettingsSidebarView.swift): column range widened to 260/280/320 so the longest sub-row label has real room at the minimum window size.SettingsContainerView.swift):minWidthbumped from 780 → 820 to keep the detail pane at a comfortable ~560pt alongside the wider sidebar.SettingsCategory.swift):metasection given the title"Info"so SwiftUI renders an explicit group boundary instead of silent inter-section spacing.Confidence Score: 4/5
Safe to merge — all three changed files contain only layout constant and string-literal changes with no behavioral side effects.
The window's minWidth nudges up by 40pt and a section header string changes from absent to Info; neither touches logic, data, or user state. The only finding is a stale (240) reference in a comment that should now read (280) to match the updated ideal column width.
The stale comment in SettingsContainerView.swift is the only line worth a second look.
Important Files Changed
metasection the title "Info" so the gap between Permissions and About reads as a deliberate section boundary rather than stray spacing.minWidthfrom 780 → 820 to match the wider sidebar; contains one stale comment that still references the old ideal width of 240 instead of the new 280.Comments Outside Diff (1)
Cotabby/UI/Settings/SettingsContainerView.swift, line 54 (link)Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Reviews (1): Last reviewed commit: "Widen Settings sidebar and label the orp..." | Re-trigger Greptile