Skip to content

Fix translucent menu bar popup background on macOS 26 #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FuJacob merged 2 commits into from
Jun 5, 2026
Merged

Fix translucent menu bar popup background on macOS 26 #566

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94e1d11
Fix translucent menu bar popup background on macOS 26
FuJacob Jun 5, 2026
f053b3c
Limit opaque popup fill to macOS 26, keep material on 15-25
FuJacob Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions Cotabby/UI/MenuBarView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,12 +365,18 @@ struct MenuBarView: View {
private struct MenuBarWindowBackgroundModifier: ViewModifier {
@ViewBuilder
func body(content: Content) -> some View {
if #available(macOS 15.0, *) {
// MenuBarExtra's `.window` style already gives us native rounded window chrome.
// On newer macOS builds, leaving the root fill implicit can make SwiftUI draw a
// second, inset window-colored rectangle inside that chrome. A container background
// belongs to the hosting window instead of this view's local bounds, so the fill
// reaches the native rounded frame and avoids the double-border look.
if #available(macOS 26.0, *) {
// macOS 26 Liquid Glass renders the `.windowBackground` *material* as translucent
// glass, so the app/desktop behind the popup bleeds through and the native chrome and
// shadow detach from the content, worst on light backgrounds (issue #492). Fill with
// an opaque window *color* instead so the popup reads as one solid rounded panel.
content.containerBackground(Color(nsColor: .windowBackgroundColor), for: .window)
} else if #available(macOS 15.0, *) {
// MenuBarExtra's `.window` style already gives us native rounded window chrome. Place
// the fill at the hosting window instead of this view's local bounds so it reaches the
// native rounded frame as one surface (avoids the double-border look fixed in #403).
// The `.windowBackground` material renders correctly on macOS 15 through pre-26, so
// keep it there to preserve the vibrant appearance and only patch the 26 regression.
content.containerBackground(.windowBackground, for: .window)
} else {
content
Expand Down