Skip to content

Onboarding: wrap long Custom template description to satisfy line_length lint#608

Merged
FuJacob merged 1 commit into
mainfrom
chore/onboarding-lint-and-launch-at-login
Jun 5, 2026
Merged

Onboarding: wrap long Custom template description to satisfy line_length lint#608
FuJacob merged 1 commit into
mainfrom
chore/onboarding-lint-and-launch-at-login

Conversation

@FuJacob
Copy link
Copy Markdown
Owner

@FuJacob FuJacob commented Jun 5, 2026

Summary

Wraps the Custom onboarding template's description string across two lines so it fits within the 140-char line_length SwiftLint rule. Pure formatting change, no behavior impact.

Validation

swiftlint lint --quiet
# exit 0
xcodebuild -project Cotabby.xcodeproj -scheme Cotabby -destination 'platform=macOS' build -derivedDataPath build/DerivedData
# ** BUILD SUCCEEDED **

Linked issues

None.

Greptile Summary

This PR reformats a single long string literal in OnboardingTemplate.swift by splitting it across two lines with a compile-time + concatenation, bringing it within the SwiftLint 140-character line_length limit. The trailing space on the first fragment preserves the word boundary correctly.

  • Splits the .custom case detail string into two adjacent string literals joined by +; Swift folds these at compile time, so the runtime value is unchanged.

Confidence Score: 5/5

Pure formatting change that splits a string literal for linting compliance; the concatenated string is identical at runtime.

The only modified line is a string literal split into two adjacent fragments joined by +. Swift evaluates adjacent string concatenation at compile time, so the value returned from detail for the .custom case is byte-for-byte identical before and after this change. No logic, types, or data flow are affected.

No files require special attention.

Important Files Changed

Filename Overview
Cotabby/Models/OnboardingTemplate.swift Single-line string literal in detail (.custom case) split across two lines using compile-time concatenation to satisfy the SwiftLint 140-char line_length rule. No behavioral change.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["OnboardingTemplate.detail (computed var)"] --> B{switch self}
    B -->|.quick| C["Short, snappy completions…"]
    B -->|.everyday| D["A balance of speed and quality…"]
    B -->|.powerful| E["Longer suggestions and higher quality…"]
    B -->|.custom| F["Returning users keep every setting… (line 1)\n+ New users start from Cotabby's lean defaults… (line 2)"]
    F --> G["Compile-time string concatenation\n→ identical runtime String value"]
Loading

Reviews (1): Last reviewed commit: "Onboarding: wrap long Custom template de..." | Re-trigger Greptile

@FuJacob FuJacob merged commit 0dce193 into main Jun 5, 2026
4 checks passed
@FuJacob FuJacob deleted the chore/onboarding-lint-and-launch-at-login branch June 5, 2026 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant