Onboarding: wrap long Custom template description to satisfy line_length lint#608
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wraps the Custom onboarding template's description string across two lines so it fits within the 140-char
line_lengthSwiftLint rule. Pure formatting change, no behavior impact.Validation
Linked issues
None.
Greptile Summary
This PR reformats a single long string literal in
OnboardingTemplate.swiftby splitting it across two lines with a compile-time+concatenation, bringing it within the SwiftLint 140-characterline_lengthlimit. The trailing space on the first fragment preserves the word boundary correctly..customcasedetailstring into two adjacent string literals joined by+; Swift folds these at compile time, so the runtime value is unchanged.Confidence Score: 5/5
Pure formatting change that splits a string literal for linting compliance; the concatenated string is identical at runtime.
The only modified line is a string literal split into two adjacent fragments joined by
+. Swift evaluates adjacent string concatenation at compile time, so the value returned fromdetailfor the.customcase is byte-for-byte identical before and after this change. No logic, types, or data flow are affected.No files require special attention.
Important Files Changed
detail(.customcase) split across two lines using compile-time concatenation to satisfy the SwiftLint 140-charline_lengthrule. No behavioral change.Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A["OnboardingTemplate.detail (computed var)"] --> B{switch self} B -->|.quick| C["Short, snappy completions…"] B -->|.everyday| D["A balance of speed and quality…"] B -->|.powerful| E["Longer suggestions and higher quality…"] B -->|.custom| F["Returning users keep every setting… (line 1)\n+ New users start from Cotabby's lean defaults… (line 2)"] F --> G["Compile-time string concatenation\n→ identical runtime String value"]Reviews (1): Last reviewed commit: "Onboarding: wrap long Custom template de..." | Re-trigger Greptile