Skip to content

Add per-app enable and disable controls#63

Merged
FuJacob merged 4 commits into
mainfrom
jafu/add-disable-per-app
Apr 28, 2026
Merged

Add per-app enable and disable controls#63
FuJacob merged 4 commits into
mainfrom
jafu/add-disable-per-app

Conversation

@FuJacob

@FuJacob FuJacob commented Apr 24, 2026

Copy link
Copy Markdown
Owner

What does this PR do?

Briefly describe the changes.

  • Adds a persisted per-app disabled blocklist keyed by bundle identifier, with display names stored only for Settings UI metadata.
  • Adds menu-bar controls for Enable Globally and Enable in {AppName}, plus a Settings Disabled Apps list with live app icons and remove actions.
  • Routes per-app disabled state through the central suggestion availability evaluator so generation, overlays, and Tab acceptance all respect the same policy.

Why is this necessary?

Explain the problem you are solving.

  • Users need to disable Tabby in specific apps without turning autocomplete off globally.
  • The root issue was that the existing gate only understood global enablement, permissions, and focus support, so app-specific preferences had no single reliable enforcement point.
  • Closes Add per-app enable/disable controls #1.
image image

Validation:

  • xcodebuild build-for-testing -scheme tabby -destination 'platform=macOS,arch=arm64' passed.
  • Full xcodebuild test is still blocked locally by the XCTest bundle signing mismatch between the host app and test bundle.

@FuJacob FuJacob requested a review from Jam-Cai April 24, 2026 01:30
@Jam-Cai

Jam-Cai commented Apr 27, 2026

Copy link
Copy Markdown
Collaborator

Also handle the linting errors before merging

@FuJacob FuJacob merged commit 279a864 into main Apr 28, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add per-app enable/disable controls

2 participants