Add missing autocomplete test coverage#90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds broad unit coverage for Tabby's autocomplete support logic so request construction, prompt policy, normalization, reconciliation, focus capability scoring, overlay presentation, and async work cancellation are protected by tests. Also tightens ghost-text color hex parsing after the new value-model tests exposed that malformed strings could be accepted too loosely.
Validation
I also ran the normal signed
xcodebuild test; it still fails before executing tests because the app-hosted test bundle and host app have different Team IDs locally:mapping process and mapped file (non-platform) have different Team IDs.Linked issues
None.
Risk / rollout notes
Most of this PR is test-only. The only runtime behavior change is stricter six-digit RGB validation in
SuggestionTextColorCodec.nsColor(fromHex:), which rejects malformed persisted or user-provided color strings instead of partially scanning them.