fix: ignore prefix syntax not in prefix position#1229
Merged
Conversation
Contributor
|
@Fuco1 I'd appreciate it if you can take a look at this one, as it's affecting Clojure users. (that's how the PR came to my attention) |
|
I tried this commit, and it's not fixing the issue described in #1212 |
|
@deejayem you're right. My configuration was bad, and I did not pull the right commit. This fixes the issue as well for me. |
|
@Fuco1 I've been using this since it was created, and (after the second commit) it's been working without any issues. It would be great if this could be merged, as I know a lot of people are affected by the bug (since names ending with ? are common in Clojure). |
Owner
|
Thank you everybody for the work and investigation and test cases. I'm so sorry it took me two months to get to this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1212 by ignoring the prefix syntax flag once point is inside the symbol.
I've added a few tests that hopefully illustrate the issue/expected behaviour.