feat(repo): Optional AWS assumable role #457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchristopher
requested review from
cue8it,
luizstacio,
pedronauck and
rodrigobranas
as code owners
pedronauck
previously approved these changes
Apr 16, 2025
mchristopher
changed the title
mchristopher
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the AWS SDK client to support optionally assuming a specified role. The current iteration assumes that a role will always need to be assumed, which is not always the case.
Also, the current code looks for
AWS_ROLE_ARN, which is a reserved environment variable name by EKS, so this PR modifies it toAWS_ASSUME_ROLE_ARNso it is clear what the intention is when someone uses the value.